From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB2D7C432C0 for ; Wed, 27 Nov 2019 08:50:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A87CE204FD for ; Wed, 27 Nov 2019 08:50:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A87CE204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4FE496B0367; Wed, 27 Nov 2019 03:50:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B0136B0369; Wed, 27 Nov 2019 03:50:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C7B16B036B; Wed, 27 Nov 2019 03:50:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id 2288F6B0367 for ; Wed, 27 Nov 2019 03:50:12 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id D0C462495 for ; Wed, 27 Nov 2019 08:50:11 +0000 (UTC) X-FDA: 76201435422.09.nose83_58f4ab52f8821 X-HE-Tag: nose83_58f4ab52f8821 X-Filterd-Recvd-Size: 4458 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Nov 2019 08:50:11 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id a131so1827808wme.5 for ; Wed, 27 Nov 2019 00:50:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ImdFufuCLABk5owE8eytpQBnf5CgqpycdtGsCA5UGN0=; b=h81cGxwlmvYbegvGeTP6T700kxJMIuBZnMCrJOUy6muyRbyBsF2I0cKKKiY6bBWDbw 9Hk/QyGSyoTm4OF83SNEIeKP5W0XorO/0eavLShpkNdChvtfqbpAT4sQU81XwodaTm28 sTEg4mCMAKwYvCeIqteTjlxiR1rL7GY7JBw+zKKwYM+7uVUfUs6XgBrw8klUWJIendJh 9Wd7r7chtrfmI8ZWR5mn68g5Vk0AJV2YPdZrmbcTirNjfJSfbGPKXwvMZzTs3w/I9gEK i59RmK/3PByUY+me51b3+mnO19wqXhA7Gj4Sgv5Nxug/Kzn1FULxb2WFekYdXNBA+fl/ f57A== X-Gm-Message-State: APjAAAXX0t0XwLFgVkCd31r/56Y1GZvgZwzOQmPZ9h1uu2dCbqU8jo53 ORCHd1GLWAaY+AyazkkPtEM= X-Google-Smtp-Source: APXvYqw8RWSr4foVA5g0pWSg5i8S+1/nelRYLyqWD8O/YCVpejH/DKWzrSxz5qb/ndIYzeuHmctHug== X-Received: by 2002:a7b:c38c:: with SMTP id s12mr3246481wmj.84.1574844610057; Wed, 27 Nov 2019 00:50:10 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id l10sm19891393wrg.90.2019.11.27.00.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2019 00:50:09 -0800 (PST) Date: Wed, 27 Nov 2019 09:50:08 +0100 From: Michal Hocko To: Qian Cai Cc: Pengfei Li , "lixinhai.lxh@gmail.com" , akpm , mgorman , Vlastimil Babka , cl , "iamjoonsoo.kim" , guro , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [RFC v1 00/19] Modify zonelist to nodelist v1 Message-ID: <20191127085008.GM20912@dhcp22.suse.cz> References: <20191125083948.GC31714@dhcp22.suse.cz> <828BAB69-4B46-418F-A5E2-35B0756340D0@lca.pw> <20191126154101.GJ20912@dhcp22.suse.cz> <8B426079-6091-4898-8D77-609915C273E8@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8B426079-6091-4898-8D77-609915C273E8@lca.pw> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.005393, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 26-11-19 14:04:06, Qian Cai wrote: >=20 >=20 > > On Nov 26, 2019, at 10:41 AM, Michal Hocko wrote: > >=20 > > On Tue 26-11-19 10:30:56, Qian Cai wrote: > >>=20 > >>=20 > >>> On Nov 25, 2019, at 3:39 AM, Michal Hocko wrote= : > >>>=20 > >>> People do care about ZONE_MOVABLE and if there is a non-movable mem= ory > >>> sitting there then it is a bug. Please report that. > >>=20 > >> It is trivial to test yourself if you ever care. Just pass kernelcor= e=3D > >> to as many NUMA machines you could find, an then test if ever possib= le > >> to offline those memory. > >=20 > > I definitely do care if you can provide more details (ideally in a > > separate email thread). I am using movable memory for memory hotplug > > usecases and so far I do not remember any kernel/non-movable allocati= ons > > would make it in - modulo bugs when somebody might use __GFP_MOVABLE > > when it is not appropriate. > >=20 >=20 > I don=E2=80=99t think it is anything to do with __GFP_MOVABLE. It is ab= out booting a kernel > with either passing kernelcore=3D or movablecore=3D. Then, those ZONE_M= OVABLE will > have non-movable pages which looks like those from vmemmap_populate(). OK, I see. This looks like a bug in kernelcore/movablecore. And honestly I wouldn't be surprised because these are hacks that should have been removed. I have even attempted to do that because their main usecase is mostly gone. There were some objections though... > How do you create ZONE_MOVALBLE in this first place?=20 The most common usecase I work with is to use movable_node parameter which makes whole nodes marked as hotplugable to be moved to ZONE_MOVABLE. --=20 Michal Hocko SUSE Labs