From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B70C432C0 for ; Tue, 26 Nov 2019 16:30:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 206FD2071A for ; Tue, 26 Nov 2019 16:30:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="Y05G/JE8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 206FD2071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 962C46B02B9; Tue, 26 Nov 2019 11:30:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9137A6B0325; Tue, 26 Nov 2019 11:30:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 802816B0326; Tue, 26 Nov 2019 11:30:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id 650776B02B9 for ; Tue, 26 Nov 2019 11:30:20 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 10086181AEF1E for ; Tue, 26 Nov 2019 16:30:20 +0000 (UTC) X-FDA: 76198966200.05.farm52_77377fbe6824b X-HE-Tag: farm52_77377fbe6824b X-Filterd-Recvd-Size: 4027 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Nov 2019 16:30:19 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id y10so22040723qto.3 for ; Tue, 26 Nov 2019 08:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Drt2W1XYSj4RyGZyntpQcfTOwrpNsPcBpejFN/TNCqM=; b=Y05G/JE8664v8vHY5DEDydV05rmBl4jjZjy3Udyx8GF8QgJPW6bq+6qQA9v/LVlqos TZRmz+ZQkOesuKWEnsT+7SdyiZhXfS9K4/IvSGYcSjdLg1n13VKzeokr9Xp13Pps2BWm VumHNmWD5WfqFzfP//qGR5tAdl/fvIIGPVh1/srRYlZ3qx0eEoOtU490qUUGEmlbNbSG qTvVsPJPCm0pmPsw73bAePFXXPXJU9J9YVBEHE68tjFLx8KNo4VYX5eHsXcGCHmNB5lT 6r0YLiui6R4973U5Qu5jNAUWCiY+b7fEAaTIMHdGmnG0lLvO1WCikhzyxcjbOshV4Lly 7eBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Drt2W1XYSj4RyGZyntpQcfTOwrpNsPcBpejFN/TNCqM=; b=oEI1ynaHD5GIUepsN8TXELee2VRWO98yU2swwp08vpmW/H6rf9A3f5mXnB7DsA6Zib iGqz/QQWmCBHg2FEfDke2diio9WItADX2HNi8QA6e4/0plmo6BlR9SMDFrH/zoa7VL64 TO7MitP3kPaVFY8C+ixG6iuDKOCEIEhodeC/DTaI+QSiakQw8cySDOYsCPhfw+wrbdur F26z8d6T6vf2gsRAH5LdIbqAN8r8ghl74D5y19Qv1a4ZSnPlpQdcjt8VELWS2knZDPk9 tfXy0iPOUgHX0dgfmAogtnO5foamrCfr9aVwK9O8bhdaoAOlKRwkfsdaMRwTjMctTFex WbYA== X-Gm-Message-State: APjAAAUj8a6xKFnWMA24a4A85yi4LOAdk01Fzjan9cF4ydrCjhTAOBUN fGUWMqX2+CXVaAw7ahakrzMruw== X-Google-Smtp-Source: APXvYqzWopHdCDsLHgT8zXMeRRhOMGJsJCMa5a/a2+gXYO+79W+Pg133NRpbIxpJoFqWavuhjRz1QQ== X-Received: by 2002:aed:20e5:: with SMTP id 92mr24862526qtb.294.1574785818236; Tue, 26 Nov 2019 08:30:18 -0800 (PST) Received: from localhost ([2620:10d:c091:500::3:4408]) by smtp.gmail.com with ESMTPSA id f6sm5333866qkk.12.2019.11.26.08.30.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 08:30:17 -0800 (PST) Date: Tue, 26 Nov 2019 11:30:16 -0500 From: Johannes Weiner To: Yafang Shao Cc: mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, Michal Hocko Subject: Re: [PATCH] mm, memcg: avoid oom if cgroup is not populated Message-ID: <20191126163016.GB609004@cmpxchg.org> References: <1574773369-1634-1-git-send-email-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1574773369-1634-1-git-send-email-laoar.shao@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 26, 2019 at 08:02:49AM -0500, Yafang Shao wrote: > There's one case that the processes in a memcg are all exit (due to OOM > group or some other reasons), but the file page caches are still exist. > These file page caches may be protected by memory.min so can't be > reclaimed. If we can't success to restart the processes in this memcg or > don't want to make this memcg offline, then we want to drop the file page > caches. > The advantage of droping this file caches is it can avoid the reclaimer > (either kswapd or direct) scanning and reclaiming pages from all memcgs > exist in this system, because currently the reclaimer will fairly reclaim > pages from all memcgs if the system is under memory pressure. > The possible method to drop these file page caches is setting the > hard limit of this memcg to 0. Unfortunately this may invoke the OOM killer > and generates lots of misleading outputs, that should not happen. You can set memory.high instead...?