From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 633BAC432C0 for ; Mon, 25 Nov 2019 15:46:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3046420863 for ; Mon, 25 Nov 2019 15:46:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3046420863 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B47A26B05C7; Mon, 25 Nov 2019 10:46:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF9356B05DB; Mon, 25 Nov 2019 10:46:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0ECA6B05DC; Mon, 25 Nov 2019 10:46:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0186.hostedemail.com [216.40.44.186]) by kanga.kvack.org (Postfix) with ESMTP id 88FBF6B05C7 for ; Mon, 25 Nov 2019 10:46:55 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 43559180AD822 for ; Mon, 25 Nov 2019 15:46:55 +0000 (UTC) X-FDA: 76195227990.08.crook00_7693dc8f0c75b X-HE-Tag: crook00_7693dc8f0c75b X-Filterd-Recvd-Size: 4931 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Nov 2019 15:46:54 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id n5so6398026wmc.0 for ; Mon, 25 Nov 2019 07:46:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OuIgeyITz3hMqeZdtOyVywD/hNAEdNGAJ5DgsDKYZg8=; b=PppRpSwXXWhV3VPH8F9xjovGuXf+WFrLACBB4i/MJFQ3/5UQGv3b9OmQOxy9yI+H5q I6UZtOsz/Y+zjlvF5Rh2WrMgpKqsTKQofLVE2+ewUuMZQjXGjkc2I8LkmB6pn9LMi+tc K+7F11BVdBmSxOQNXJ+SCw4P/3StpWmQlkElg9ECXXcuWG0wKh5NMPR31XTZsZwrYbVj QTPe08V9QqlQ/AfezawR0UDufM/NNNXuOXc7bKk/LDg2C3MnPQkbBi1+MmAHwuopldco ITZihV665aA1QVqwNLslzpV/DQqiFfGR9+hdI36J6FLjx6aZP69x/KHGxxUSY1oVpZzV rMPg== X-Gm-Message-State: APjAAAXwfeaYymd8hYPy2QaRMrSGDUrmDMVIMI7v17lon32usslsOpsY HU32x2uuxNd+dmem+WP7f7o= X-Google-Smtp-Source: APXvYqykJqodyyfq8OLxx0nqs51Z8v7G5EX8tYJjoHrygdNlt0J5kGY9cBZxHsD+/it0jF7dfO/jEg== X-Received: by 2002:a05:600c:1:: with SMTP id g1mr22657988wmc.131.1574696813540; Mon, 25 Nov 2019 07:46:53 -0800 (PST) Received: from localhost (ip-37-188-171-132.eurotel.cz. [37.188.171.132]) by smtp.gmail.com with ESMTPSA id u14sm11051978wrm.51.2019.11.25.07.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2019 07:46:52 -0800 (PST) Date: Mon, 25 Nov 2019 16:46:51 +0100 From: Michal Hocko To: Pengfei Li Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, vbabka@suse.cz, cl@linux.com, iamjoonsoo.kim@lge.com, guro@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC v1 00/19] Modify zonelist to nodelist v1 Message-ID: <20191125154651.GA31703@dhcp22.suse.cz> References: <20191121151811.49742-1-fly@kernel.page> <20191121180401.GL23213@dhcp22.suse.cz> <20191122230543.2f106c80.fly@kernel.page> <20191125084058.GD31714@dhcp22.suse.cz> <20191125224603.688cb69c.fly@kernel.page> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191125224603.688cb69c.fly@kernel.page> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 25-11-19 22:46:03, Pengfei Li wrote: > On Mon, 25 Nov 2019 09:40:58 +0100 > Michal Hocko wrote: > > > On Fri 22-11-19 23:05:43, Pengfei Li wrote: > > > On Thu, 21 Nov 2019 19:04:01 +0100 > > > Michal Hocko wrote: > > > > > > > On Thu 21-11-19 23:17:52, Pengfei Li wrote: > > > > [...] > > > > > Since I don't currently have multiple node NUMA systems, I > > > > > would be grateful if anyone would like to test this series of > > > > > patches. > > > > > > > > I didn't really get to think about the actual patchset. From a > > > > very quick glance I am wondering whether we need to optimize as > > > > there are usually only small amount of numa nodes. But I am quite > > > > busy so I cannot really do any claims. > > > > > > Thanks for your comments. > > > > > > I think it's time to modify the zonelist to nodelist because the > > > zonelist is always in node order and the page reclamation is based > > > on node. > > > > > > I will do more performance testing to show that multi-node systems > > > will benefit from this series of patches. > > > > Sensible performance numbers on multiple workloads (ideally some real > > world ones rather than artificial microbenchmarks) is essential for a > > performance optimization that is this large. > > > Thank you for your suggestion. > > But this is probably a bit difficult because I don't have a NUMA server > to do real-world workload testing. For this particular feature you really do not need any real NUMA server. Your patch shouldn't introduce NUMA locality. All you are aiming for is to optimize the zone list iteration. > I will do as many performance benchmarks as possible, just like Mel > Gorman's "Move LRU page reclaim from zones to nodes v9" > (https://lwn.net/Articles/694121/). Be aware that this will be quite time consuming and non-trivial to process/evaluate. Not that I want to discourage you from this endeavor but it is always good to think whether your final goal really has a potential to a visible optimization. I might be wrong but only the page allocator should really be the hot path which iterates over zonelist so a microbenchmark targeting this path would be something I would start with. Unless there are some really nice results from there I would lose more time with other benchmarks. -- Michal Hocko SUSE Labs