From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B596AC432C0 for ; Mon, 25 Nov 2019 08:41:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C1AD2071E for ; Mon, 25 Nov 2019 08:41:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C1AD2071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2F0586B05B6; Mon, 25 Nov 2019 03:41:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C85B6B05B7; Mon, 25 Nov 2019 03:41:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B7136B05B8; Mon, 25 Nov 2019 03:41:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id 046116B05B6 for ; Mon, 25 Nov 2019 03:41:02 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 9F7F43D0F for ; Mon, 25 Nov 2019 08:41:01 +0000 (UTC) X-FDA: 76194154722.06.lead93_2604d20065e51 X-HE-Tag: lead93_2604d20065e51 X-Filterd-Recvd-Size: 3540 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Nov 2019 08:41:01 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id n188so12898550wme.1 for ; Mon, 25 Nov 2019 00:41:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jBkEVM1ZML9yppqM2XGG1VzJZp8iZsSYQ50Ax01TjF4=; b=ax4mXZb9bJ1RnQZsAncG1eH22ovyQ2ycT+C7OGYxGbvMd9bAndEAM1tncRtYMG5//T ecfGSfZAlOfvL5Gempuo3cwf7mQwEgPj/HZepsMFpz67cU8Wuk7KPzSL9IGP4szz3ps7 F4DNZPWdAovUi/kUBHjMM2hv/REKs2EM2U96z9/Cq9TTlpC3FW5MV7YJBKW8znPkEsM4 5jhaw4dcFpMAiXJ3teyWkpkA5uDbKjbC1nqLYIhdVMi/tMNc8Q0Z17IFy94M6iW0WSST H/t+7HI2l+W4ovHRiVdWnTH5MlI5waiBafIgYkrnCEK3HQL64dgNJBXU1EQhD8ZNZEpf PbBw== X-Gm-Message-State: APjAAAWEZRqnToL9dpOEMRhsu0IcfG0uCYaTqf2IgiVA/aHqrMTlPCa6 JyHvqUNl1y4Q/40EiqhIZKw= X-Google-Smtp-Source: APXvYqzYLiBWDU9gior4n3WX5fyulWr1KDwvTOmKNx/1LFUP4ZLZcQE6+Xf7GcxPfhAdk9oQKXqP0g== X-Received: by 2002:a7b:c8c2:: with SMTP id f2mr26246965wml.99.1574671260222; Mon, 25 Nov 2019 00:41:00 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id o189sm7943305wmo.23.2019.11.25.00.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2019 00:40:59 -0800 (PST) Date: Mon, 25 Nov 2019 09:40:58 +0100 From: Michal Hocko To: Pengfei Li Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, vbabka@suse.cz, cl@linux.com, iamjoonsoo.kim@lge.com, guro@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC v1 00/19] Modify zonelist to nodelist v1 Message-ID: <20191125084058.GD31714@dhcp22.suse.cz> References: <20191121151811.49742-1-fly@kernel.page> <20191121180401.GL23213@dhcp22.suse.cz> <20191122230543.2f106c80.fly@kernel.page> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191122230543.2f106c80.fly@kernel.page> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 22-11-19 23:05:43, Pengfei Li wrote: > On Thu, 21 Nov 2019 19:04:01 +0100 > Michal Hocko wrote: > > > On Thu 21-11-19 23:17:52, Pengfei Li wrote: > > [...] > > > Since I don't currently have multiple node NUMA systems, I would be > > > grateful if anyone would like to test this series of patches. > > > > I didn't really get to think about the actual patchset. From a very > > quick glance I am wondering whether we need to optimize as there are > > usually only small amount of numa nodes. But I am quite busy so I > > cannot really do any claims. > > Thanks for your comments. > > I think it's time to modify the zonelist to nodelist because the > zonelist is always in node order and the page reclamation is based on > node. > > I will do more performance testing to show that multi-node systems will > benefit from this series of patches. Sensible performance numbers on multiple workloads (ideally some real world ones rather than artificial microbenchmarks) is essential for a performance optimization that is this large. -- Michal Hocko SUSE Labs