From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F17C432C0 for ; Thu, 21 Nov 2019 16:21:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DD05E20692 for ; Thu, 21 Nov 2019 16:21:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD05E20692 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 94AF66B035A; Thu, 21 Nov 2019 11:21:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D46C6B035C; Thu, 21 Nov 2019 11:21:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F49C6B035A; Thu, 21 Nov 2019 11:21:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id 641D36B035A for ; Thu, 21 Nov 2019 11:21:56 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 1B1088249980 for ; Thu, 21 Nov 2019 16:21:56 +0000 (UTC) X-FDA: 76180801032.03.start94_2ded3367e4c0c X-HE-Tag: start94_2ded3367e4c0c X-Filterd-Recvd-Size: 2696 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Nov 2019 16:21:55 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F3AB9B399; Thu, 21 Nov 2019 16:21:53 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 6FA2C1E484C; Thu, 21 Nov 2019 17:21:53 +0100 (CET) Date: Thu, 21 Nov 2019 17:21:53 +0100 From: Jan Kara To: Konstantin Khlebnikov Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Jan Kara , Alexander Viro Subject: Re: [PATCH v2 1/3] fs: remove redundant cache invalidation after async direct-io write Message-ID: <20191121162153.GA18158@quack2.suse.cz> References: <157270037850.4812.15036239021726025572.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <157270037850.4812.15036239021726025572.stgit@buzz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat 02-11-19 16:12:58, Konstantin Khlebnikov wrote: > Function generic_file_direct_write() invalidates cache at entry. Second > time this should be done when request completes. But this function calls > second invalidation at exit unconditionally even for async requests. > > This patch skips second invalidation for async requests (-EIOCBQUEUED). > > Signed-off-by: Konstantin Khlebnikov Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > mm/filemap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 85b7d087eb45..288e38199068 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -3218,9 +3218,11 @@ generic_file_direct_write(struct kiocb *iocb, struct iov_iter *from) > * Most of the time we do not need this since dio_complete() will do > * the invalidation for us. However there are some file systems that > * do not end up with dio_complete() being called, so let's not break > - * them by removing it completely > + * them by removing it completely. > + * > + * Skip invalidation for async writes or if mapping has no pages. > */ > - if (mapping->nrpages) > + if (written > 0 && mapping->nrpages) > invalidate_inode_pages2_range(mapping, > pos >> PAGE_SHIFT, end); > > -- Jan Kara SUSE Labs, CR