From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21268C432C0 for ; Thu, 21 Nov 2019 15:20:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E28B220674 for ; Thu, 21 Nov 2019 15:20:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E28B220674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.page Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9A1AB6B032F; Thu, 21 Nov 2019 10:20:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92B7D6B0330; Thu, 21 Nov 2019 10:20:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81A3C6B0331; Thu, 21 Nov 2019 10:20:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id 6909D6B032F for ; Thu, 21 Nov 2019 10:20:27 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 29013181AEF0B for ; Thu, 21 Nov 2019 15:20:27 +0000 (UTC) X-FDA: 76180646094.10.hall84_5b33e58a15f00 X-HE-Tag: hall84_5b33e58a15f00 X-Filterd-Recvd-Size: 2471 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Nov 2019 15:20:26 +0000 (UTC) X-Originating-IP: 153.3.140.100 Received: from localhost.localdomain.localdomain (unknown [153.3.140.100]) (Authenticated sender: fly@kernel.page) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id E922A1C000F; Thu, 21 Nov 2019 15:20:15 +0000 (UTC) From: Pengfei Li To: akpm@linux-foundation.org Cc: mgorman@techsingularity.net, mhocko@kernel.org, vbabka@suse.cz, cl@linux.com, iamjoonsoo.kim@lge.com, guro@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pengfei Li Subject: [RFC v1 05/19] mm, slab: use for_each_node in fallback_alloc() Date: Thu, 21 Nov 2019 23:17:57 +0800 Message-Id: <20191121151811.49742-6-fly@kernel.page> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191121151811.49742-1-fly@kernel.page> References: <20191121151811.49742-1-fly@kernel.page> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In fallback_alloc(), we want to traverse node instead of zone, so use for_each_node instead of for_each_zone. Signed-off-by: Pengfei Li --- mm/slab.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/mm/slab.c b/mm/slab.c index b9a1353cf2ab..b94c06934459 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -3103,12 +3103,11 @@ static void *alternate_node_alloc(struct kmem_cac= he *cachep, gfp_t flags) */ static void *fallback_alloc(struct kmem_cache *cache, gfp_t flags) { - struct nodelist *nodelist; - struct nlist_traverser t; - struct zone *zone; enum zone_type high_zoneidx =3D gfp_zone(flags); void *obj =3D NULL; struct page *page; + struct nodelist *nodelist; + struct nlist_traverser t; int nid; unsigned int cpuset_mems_cookie; =20 @@ -3124,10 +3123,8 @@ static void *fallback_alloc(struct kmem_cache *cac= he, gfp_t flags) * Look through allowed nodes for objects available * from existing per node queues. */ - for_each_zone_nlist(zone, &t, nodelist, high_zoneidx) { - nid =3D zone_to_nid(zone); - - if (cpuset_zone_allowed(zone, flags) && + for_each_node_nlist(nid, &t, nodelist, high_zoneidx) { + if (cpuset_node_allowed(nid, flags) && get_node(cache, nid) && get_node(cache, nid)->free_objects) { obj =3D ____cache_alloc_node(cache, --=20 2.23.0