From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFFFC432C0 for ; Thu, 21 Nov 2019 15:22:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 06FE720674 for ; Thu, 21 Nov 2019 15:22:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06FE720674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.page Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B25E56B034D; Thu, 21 Nov 2019 10:22:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD6716B034E; Thu, 21 Nov 2019 10:22:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ECC46B034F; Thu, 21 Nov 2019 10:22:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 8914E6B034D for ; Thu, 21 Nov 2019 10:22:33 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 44C0152A6 for ; Thu, 21 Nov 2019 15:22:33 +0000 (UTC) X-FDA: 76180651386.15.shape62_6d8a857d45449 X-HE-Tag: shape62_6d8a857d45449 X-Filterd-Recvd-Size: 2861 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Nov 2019 15:22:32 +0000 (UTC) X-Originating-IP: 153.3.140.100 Received: from localhost.localdomain.localdomain (unknown [153.3.140.100]) (Authenticated sender: fly@kernel.page) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 2425C1C001C; Thu, 21 Nov 2019 15:22:24 +0000 (UTC) From: Pengfei Li To: akpm@linux-foundation.org Cc: mgorman@techsingularity.net, mhocko@kernel.org, vbabka@suse.cz, cl@linux.com, iamjoonsoo.kim@lge.com, guro@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pengfei Li Subject: [RFC v1 17/19] mm, memory_hotplug: cleanup online_pages() Date: Thu, 21 Nov 2019 23:18:09 +0800 Message-Id: <20191121151811.49742-18-fly@kernel.page> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191121151811.49742-1-fly@kernel.page> References: <20191121151811.49742-1-fly@kernel.page> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a cleanup patch. In online_pages(), rename the local variable need_zonelists_rebuild to need_nodelists_rebuild. Signed-off-by: Pengfei Li --- mm/memory_hotplug.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 3c63529df112..3ff55da7b225 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -760,10 +760,10 @@ struct zone * zone_for_pfn_range(int online_type, i= nt nid, unsigned start_pfn, =20 int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int on= line_type) { - unsigned long flags; + bool need_nodelists_rebuild =3D false; unsigned long onlined_pages =3D 0; + unsigned long flags; struct zone *zone; - int need_zonelists_rebuild =3D 0; int nid; int ret; struct memory_notify arg; @@ -798,7 +798,7 @@ int __ref online_pages(unsigned long pfn, unsigned lo= ng nr_pages, int online_typ * So, zonelist must be updated after online. */ if (!populated_zone(zone)) { - need_zonelists_rebuild =3D 1; + need_nodelists_rebuild =3D true; setup_zone_pageset(zone); } =20 @@ -806,7 +806,7 @@ int __ref online_pages(unsigned long pfn, unsigned lo= ng nr_pages, int online_typ online_pages_range); if (ret) { /* not a single memory resource was applicable */ - if (need_zonelists_rebuild) + if (need_nodelists_rebuild) zone_pcp_reset(zone); goto failed_addition; } @@ -820,7 +820,7 @@ int __ref online_pages(unsigned long pfn, unsigned lo= ng nr_pages, int online_typ shuffle_zone(zone); =20 node_states_set_node(nid, &arg); - if (need_zonelists_rebuild) + if (need_nodelists_rebuild) build_all_nodelists(NULL); else zone_pcp_update(zone); --=20 2.23.0