From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FCAAC432C0 for ; Tue, 19 Nov 2019 15:42:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 45A4D21D7F for ; Tue, 19 Nov 2019 15:42:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="us8sMchD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45A4D21D7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EA4E86B0006; Tue, 19 Nov 2019 10:42:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E55106B0007; Tue, 19 Nov 2019 10:42:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D45106B0008; Tue, 19 Nov 2019 10:42:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id BF1336B0006 for ; Tue, 19 Nov 2019 10:42:21 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 64A9382499B9 for ; Tue, 19 Nov 2019 15:42:21 +0000 (UTC) X-FDA: 76173443682.30.taste79_147e6eb825251 X-HE-Tag: taste79_147e6eb825251 X-Filterd-Recvd-Size: 3883 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 Nov 2019 15:42:20 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id d13so18191841qko.3 for ; Tue, 19 Nov 2019 07:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=nWs/1bjDvNuzUJtmMQammwiguABeAIM4rx8Ev82Odj4=; b=us8sMchDRqbzZLY+8PM7/pe8WsLDZaohdyGl7R3EeSoWSvgvizJcLMF0BSaCEqsdy4 NSYDM17Ete2jESTbIDna9vtA0dUXsmg6bBXQOCH48RDKNzLBxQ6mlp7dlkil/PAQ5hl4 kxrZ3bqxv5B9F8bKvIHUq5QUdUopVtt0xgGF3OfR4oa410peA1MSURbcEDbJvRagtXXW +SqQC2r8fKOXJEA7CxMEGgKlIO7ejUpU40J+VxnUNJ6vEHK8//vMrnAp2qoHjQxavaiI vz7OWx7ODCOY89S+kEdO/+LJrWWnNLTcSyv0Maq4YAOgtfhCfquKCCUXG3oySb+mCvBb 38tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nWs/1bjDvNuzUJtmMQammwiguABeAIM4rx8Ev82Odj4=; b=g6yi0s74IfneikgqO1uU53ukIqHoxum4YHtytz71uWmvyEXfVO9KifOZacImZUvx/A a5M+4hojop2UjGRb3O/mHuegGRV7/tVvkd4NyhEiUPQbijy4jNS7Mfz4G4cjpzmPHtiv VoBKHa0VpQBdvp+QLB5m95pye1j8r/fwVMaDyW0Ja7xd6Nd9JEKCifxubNZL75sSOM2I /v56yXX3VvGKuaYCOu/8ATaS86celsp1SFMULiGPH+UTU50MKWjTaLF7ClcqmjYgAEMv wJecgcAH5fNCvoqOUEnDp+lCmjKDPnlatpSUokHaYGCJs3RUisOnTCwsNnQ8whJQEjEC nMyw== X-Gm-Message-State: APjAAAWyv+o+5vmGNAYbHFecgHOAzCdlznb3PSsfHK3vAHbLM5LNqRZl 5kakwKQ81uqgi4U1tzsE+KP8cg== X-Google-Smtp-Source: APXvYqw/NhSrzyPWPQbLnED7yGzQyzSTdlwC0odTzaM2yCGhnhMYRRPM2hqTvbDK1lg4A0bgszuNRw== X-Received: by 2002:a05:620a:13c4:: with SMTP id g4mr30230662qkl.391.1574178139850; Tue, 19 Nov 2019 07:42:19 -0800 (PST) Received: from localhost ([2620:10d:c091:500::c7ac]) by smtp.gmail.com with ESMTPSA id i17sm7188612qtm.53.2019.11.19.07.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2019 07:42:19 -0800 (PST) Date: Tue, 19 Nov 2019 10:42:17 -0500 From: Johannes Weiner To: Alex Shi Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, shakeelb@google.com Subject: Re: [PATCH v4 2/9] mm/huge_memory: fix uninitialized compiler warning Message-ID: <20191119154217.GC382712@cmpxchg.org> References: <1574166203-151975-1-git-send-email-alex.shi@linux.alibaba.com> <1574166203-151975-3-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1574166203-151975-3-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Mutt/1.12.2 (2019-09-21) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 19, 2019 at 08:23:16PM +0800, Alex Shi wrote: > ../mm/huge_memory.c: In function =E2=80=98split_huge_page_to_list=E2=80= =99: > ../mm/huge_memory.c:2766:9: warning: =E2=80=98flags=E2=80=99 may be use= d uninitialized > in this function [-Wmaybe-uninitialized] > lruvec =3D lock_page_lruvec_irqsave(head, pgdata, flags); > ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Like with the previous patch, there is no lock_page_lruvec_irqsave() at this point in the series.