From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E26FC432C0 for ; Mon, 18 Nov 2019 18:28:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E6FD6222A5 for ; Mon, 18 Nov 2019 18:28:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="t5weXUGA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6FD6222A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 913C26B0008; Mon, 18 Nov 2019 13:28:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C2AF6B000A; Mon, 18 Nov 2019 13:28:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D91A6B000C; Mon, 18 Nov 2019 13:28:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 68A866B0008 for ; Mon, 18 Nov 2019 13:28:56 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 23208180AD80F for ; Mon, 18 Nov 2019 18:28:56 +0000 (UTC) X-FDA: 76170234672.26.tramp68_6b10e1cff6c4e X-HE-Tag: tramp68_6b10e1cff6c4e X-Filterd-Recvd-Size: 4729 Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Nov 2019 18:28:55 +0000 (UTC) Received: by mail-qv1-f65.google.com with SMTP id i3so6971088qvv.7 for ; Mon, 18 Nov 2019 10:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rury4ZZBdE8YLeSDPwSjljk3dVtJlEOvKyMr2vi3O/U=; b=t5weXUGAVmsQStwPj4v4X/U1MmOY95N/K56kPstKmQF4arNhyRORYSXsWauzEacMXb JqhTYeEb1S364qsmlrmH2Ac0I49RfS5VfaipBlRA4LTAeyLOUWPW1paOU7a4oRkJOiV7 k/YI7dV2R8eGFp9rKo+JiT+PlhARfTYuaQ2jSeqOp2uA0ik41qAUY+VIDzaRviKLjbWU WyiILBRcfAyWWgqTWScDeJu4fRb6NUGl2+uAnpWSMR7MIeAn5zq5kuCSVzknRMJw/kNy aPu4XUNv+4/FST7Sq5GX73fckuKvxVYDE9W+iMHnunV3Wc6J+OcNU7Hmppo4Ur3H2Qcl HvRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rury4ZZBdE8YLeSDPwSjljk3dVtJlEOvKyMr2vi3O/U=; b=D0hbwIExekMocLCWpUgkIndJMoEylMDg+u7xPmDsUgiIqhlxjwjIXqgfEQgi6ysfQR xr/6P/0JC02InSfW4BfcJExJYA0r4IbT3Z1Qx7fvP9Swzv/Y0a0VKaykMT9KDiTuyCb+ t6IP8IMG86rmrU2HzqkbeUM3soUq56MmIel7EaTJ8RCdJIpRC/KA5Dlcn9u1UXMoT17K jPmUP1CIxUn8T/n5XQHD6fZ6ZudjArXoVyePcZ3598Xoj6tmIpzoNa3zypIrAZFCdKAb S78rxz6a8GNRfumkqY/ABpAmvM3rZwJDvMvSKzNR5TR98H6WgM3RXDmuqn/DFIvctug9 uX8A== X-Gm-Message-State: APjAAAWz/3pTMRnlyQ60Mt7dbP67KMG1euC+jfMv8VyL+uYGdW2n1nqc +u0MPd09PiC4UymYE609gq/yjQ== X-Google-Smtp-Source: APXvYqyl/aARQmjBKzHTmHzbVrT8MzUIpL5E7XmWwEt1kaN/urxHlwoDGk5fd7gzop2bqCj4f4lKcg== X-Received: by 2002:a0c:df89:: with SMTP id w9mr16219834qvl.158.1574101735081; Mon, 18 Nov 2019 10:28:55 -0800 (PST) Received: from localhost ([2620:10d:c091:500::1:1113]) by smtp.gmail.com with ESMTPSA id d126sm8997866qkc.93.2019.11.18.10.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 10:28:54 -0800 (PST) Date: Mon, 18 Nov 2019 13:28:53 -0500 From: Johannes Weiner To: Qian Cai Cc: akpm@linux-foundation.org, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next v2] mm/vmscan: fix some -Wenum-conversion warnings Message-ID: <20191118182853.GC372119@cmpxchg.org> References: <1573848697-29262-1-git-send-email-cai@lca.pw> <20191118182547.GA372119@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191118182547.GA372119@cmpxchg.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 18, 2019 at 01:25:49PM -0500, Johannes Weiner wrote: > On Fri, Nov 15, 2019 at 03:11:37PM -0500, Qian Cai wrote: > > The -next commit "mm: vmscan: enforce inactive:active ratio at the > > reclaim root" [1] introduced some Clang -Wenum-conversion warnings, > > > > mm/vmscan.c:2216:39: warning: implicit conversion from enumeration type > > 'enum lru_list' to different enumeration type 'enum node_stat_item' > > [-Wenum-conversion] > > inactive = lruvec_page_state(lruvec, inactive_lru); > > ~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~ > > mm/vmscan.c:2217:37: warning: implicit conversion from enumeration type > > 'enum lru_list' to different enumeration type 'enum node_stat_item' > > [-Wenum-conversion] > > active = lruvec_page_state(lruvec, active_lru); > > ~~~~~~~~~~~~~~~~~ ^~~~~~~~~~ > > mm/vmscan.c:2746:42: warning: implicit conversion from enumeration type > > 'enum lru_list' to different enumeration type 'enum node_stat_item' > > [-Wenum-conversion] > > file = lruvec_page_state(target_lruvec, LRU_INACTIVE_FILE); > > ~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~ > > > > Since it guarantees the relative order between the LRU items, fix it by > > using NR_LRU_BASE for the translation. > > > > [1] http://lkml.kernel.org/r/20191107205334.158354-4-hannes@cmpxchg.org > > > > Signed-off-by: Qian Cai > > Acked-by: Johannes Weiner > > Thanks Qian! > > Andrew, this is a fix for "mm: vmscan: enforce inactive:active ratio > at the reclaim root". Could you please fold this into that? nvm, I see you already picked it up. Thank you!