From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA22C432C3 for ; Mon, 18 Nov 2019 12:08:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 62A4A2067D for ; Mon, 18 Nov 2019 12:08:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dj69PrK6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62A4A2067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E294C6B0006; Mon, 18 Nov 2019 07:08:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB2946B0007; Mon, 18 Nov 2019 07:08:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C79A86B000A; Mon, 18 Nov 2019 07:08:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id AD6D06B0006 for ; Mon, 18 Nov 2019 07:08:23 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 7144E180AD807 for ; Mon, 18 Nov 2019 12:08:23 +0000 (UTC) X-FDA: 76169275686.26.wool47_8368f1d011c2e X-HE-Tag: wool47_8368f1d011c2e X-Filterd-Recvd-Size: 3618 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Nov 2019 12:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uDdb1pDQwvx9Enh6ck9uQZEmy8t5nOmH+npUrGwmKoQ=; b=dj69PrK6hU4uhSbtILOtORwkvu UAgJ+yWIn/iS73f9ZnAWCaz2MFOgeOuHEStFzo4rl7J+/wsatvvBmtKULnSF2Ejpa7ZSpaAp7ypI9 Vt5/5Q4kaTewk9aWxTGYMYyu7v7MhSkeiLZH+ozs5uiCNSkLZjBDQhRScA+3Xbpd333jKFOdfHRj8 IEgNblIgLp45dLlPRoMWLjHA4HV+lZF1iWo7wjnShIljDnlZe/ymlAdgZDscXZPwGY46pDcp0vLzz BWy+4JYokBqrwj0RmN3gSnXWmKyioPvQyycQkt07R91jxw46AkvEn1mrlY02WsoGyaKUq2yvVs3l5 z5ZqehHA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWfpH-0007ns-MP; Mon, 18 Nov 2019 12:08:15 +0000 Date: Mon, 18 Nov 2019 04:08:15 -0800 From: Matthew Wilcox To: Alex Shi Cc: Shakeel Butt , Cgroups , LKML , Linux MM , Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Vlastimil Babka , Dan Williams , Michal Hocko , Wei Yang , Johannes Weiner , Arun KS Subject: Re: [PATCH v3 1/7] mm/lru: add per lruvec lock for memcg Message-ID: <20191118120815.GF20752@bombadil.infradead.org> References: <1573874106-23802-1-git-send-email-alex.shi@linux.alibaba.com> <1573874106-23802-2-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 18, 2019 at 10:44:57AM +0800, Alex Shi wrote: >=20 >=20 > =E5=9C=A8 2019/11/16 =E4=B8=8B=E5=8D=882:28, Shakeel Butt =E5=86=99=E9=81= =93: > > On Fri, Nov 15, 2019 at 7:15 PM Alex Shi = wrote: > >> > >> Currently memcg still use per node pgdat->lru_lock to guard its lruv= ec. > >> That causes some lru_lock contention in a high container density sys= tem. > >> > >> If we can use per lruvec lock, that could relief much of the lru_loc= k > >> contention. > >> > >> The later patches will replace the pgdat->lru_lock with lruvec->lru_= lock > >> and show the performance benefit by benchmarks. > >=20 > > Merge this patch with actual usage. No need to have a separate patch. >=20 > Thanks for comment, Shakeel! >=20 > Yes, but considering the 3rd, huge and un-splitable patch of actully re= placing, I'd rather to pull sth out from=20 > it. Ty to make patches a bit more readable, Do you think so? This method of splitting the patches doesn't help with the reviewability = of the patch series.