From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86733C43215 for ; Mon, 18 Nov 2019 10:29:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 625992075E for ; Mon, 18 Nov 2019 10:29:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 625992075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E9A076B0007; Mon, 18 Nov 2019 05:29:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E497B6B0008; Mon, 18 Nov 2019 05:29:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D86A36B000A; Mon, 18 Nov 2019 05:29:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id C425A6B0007 for ; Mon, 18 Nov 2019 05:29:53 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 5B9124403 for ; Mon, 18 Nov 2019 10:29:53 +0000 (UTC) X-FDA: 76169027466.20.scarf67_907efa43c4e1c X-HE-Tag: scarf67_907efa43c4e1c X-Filterd-Recvd-Size: 2361 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Nov 2019 10:29:52 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 56444AE89; Mon, 18 Nov 2019 10:29:51 +0000 (UTC) Date: Mon, 18 Nov 2019 11:29:50 +0100 From: Michal Hocko To: Hillf Danton Cc: linux-mm , Rong Chen , linux-kernel Subject: Re: [RFC v3] memcg: add memcg lru Message-ID: <20191118102950.GB14255@dhcp22.suse.cz> References: <20191117113526.5640-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191117113526.5640-1-hdanton@sina.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000032, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 17-11-19 19:35:26, Hillf Danton wrote: > > Currently soft limit reclaim (slr) is frozen, see > Documentation/admin-guide/cgroup-v2.rst for reasons. > > This work adds memcg hook into kswapd's logic to bypass slr, paving > a brick for its cleanup later. > > After b23afb93d317 ("memcg: punt high overage reclaim to > return-to-userland path"), high limit breachers (hlb) are reclaimed > one after another spiraling up through the memcg hierarchy before > returning to userspace. > > The current memcg high work helps to add the lru because we get to > collect hlb at zero price and in particular without adding changes > to the high work's behavior. > > Then a fifo list, which is essencially a simple copy of the page lru, > is needed to facilitate queuing up hlb and ripping pages off them in > round robin once kswapd starts doing its job. > > Finally new hook is added with slr's two problems addressed i.e. > hierarchy-unaware reclaim and overreclaim. > > Thanks to Rong Chen for testing. You have ignored the previous review feedback again [1]. I have nacked the patch on grounds that it is completely missing any real use case scenario or any numbers suggesting there is an actual improvement. Please do not post new versions until you make those things clear. [1] http://lkml.kernel.org/r/20191029083730.GC31513@dhcp22.suse.cz -- Michal Hocko SUSE Labs