From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53BEEC432C3 for ; Sat, 16 Nov 2019 00:08:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 140CE20740 for ; Sat, 16 Nov 2019 00:08:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="XdMvhhx7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 140CE20740 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9703E6B0005; Fri, 15 Nov 2019 19:08:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 920B76B0006; Fri, 15 Nov 2019 19:08:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85D5D6B0007; Fri, 15 Nov 2019 19:08:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 7773D6B0005 for ; Fri, 15 Nov 2019 19:08:36 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 47CBC82499A8 for ; Sat, 16 Nov 2019 00:08:36 +0000 (UTC) X-FDA: 76160204232.28.cough40_8549b49347a21 X-HE-Tag: cough40_8549b49347a21 X-Filterd-Recvd-Size: 3064 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 Nov 2019 00:08:35 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66E2520730; Sat, 16 Nov 2019 00:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573862915; bh=BJ4L9qrJoht0uLRblWQg7JYdL1y/ny6VjCVp2vX5Asw=; h=Date:From:To:Subject:In-Reply-To:References:From; b=XdMvhhx7k/NONyYyoAW+m7AtxuYNLSkXLSZ2GzgV2o7DiqAly91BIGv/NBTJALLbw 0mwvxegDQP6OFHcLQ+FbJIUd9dpArgT1GJRh41HQpvhEpSt19ZLysDQecSM4INWHYI 5R2cRUvU6G2xztbjCIxxpeD01gCkI2c1b6s1rjWM= Date: Fri, 15 Nov 2019 16:08:33 -0800 From: Andrew Morton To: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Tang Chen , Greg Kroah-Hartman , "Rafael J. Wysocki" , Keith Busch , Jiri Olsa , "Peter Zijlstra (Intel)" , Jani Nikula , Nayna Jain , Michal Hocko , Oscar Salvador , Stephen Rothwell , Dan Williams , Pavel Tatashin Subject: Re: [PATCH v3] mm/memory_hotplug: Fix try_offline_node() Message-Id: <20191115160833.beda52bc6f1145bc81960ba7@linux-foundation.org> In-Reply-To: <20191107195845.b0b3921ea146a60d042a8f64@linux-foundation.org> References: <20191102120221.7553-1-david@redhat.com> <51bdb854-a60e-d076-5dde-38481bf4a4b1@redhat.com> <20191107195845.b0b3921ea146a60d042a8f64@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 7 Nov 2019 19:58:45 -0800 Andrew Morton wrote: > On Thu, 7 Nov 2019 00:14:13 +0100 David Hildenbrand wrote: > > > > + /* > > > + * Especially offline memory blocks might not be spanned by the > > > + * node. They will get spanned by the node once they get onlined. > > > + * However, they link to the node in sysfs and can get onlined later. > > > + */ > > > + rc = for_each_memory_block(&nid, check_no_memblock_for_node_cb); > > > + if (rc) > > > return; > > > - } > > > > > > if (check_cpu_on_node(pgdat)) > > > return; > > > > > > > @Andrew, can you queued this one instead of v1 so we can give this some > > more testing? Thanks! > > Sure. > > We have a tested-by but no reviewed-by or acked-by :( > > Null pointer derefs are unpopular. Should we cc:stable? I added cc:stable and shall send it upstream unreviewed.