From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 857FFC43141 for ; Thu, 14 Nov 2019 19:20:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 488ED20727 for ; Thu, 14 Nov 2019 19:20:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="byTtSXKQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 488ED20727 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DBD456B0003; Thu, 14 Nov 2019 14:20:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6F176B0005; Thu, 14 Nov 2019 14:20:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C35D36B0006; Thu, 14 Nov 2019 14:20:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id AB3DE6B0003 for ; Thu, 14 Nov 2019 14:20:22 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 4F7B6824999B for ; Thu, 14 Nov 2019 19:20:22 +0000 (UTC) X-FDA: 76155849084.23.blade90_204e4a3955333 X-HE-Tag: blade90_204e4a3955333 X-Filterd-Recvd-Size: 3823 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Nov 2019 19:20:21 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id 15so6012072qkh.6 for ; Thu, 14 Nov 2019 11:20:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ad+hImqgLDxypIEINMZpS4Tr/4Mgv7yIFC4Nbt2V9kg=; b=byTtSXKQQYePQfHDLVfvtbTfxb+feN2Rw10WG0dnLqlQHjnp6ZqhpFGPYiTJtn9lDD 6SrXLdyjN+S+8zKLupJ0J6AOFKhKFCdKMEB0XC3KSHz3eaXrxnWfHgS8f5fTJbaHzaBw nICTABqMxTHdOrmtN6iofLY9mxUzOMb2zmHAp8FT4UsTjOojgCJymb3q1NuHBdnFW9Li Uiq6x+NEu+2qVNn+pQXfevOoGLxsvDTu+ti1pPhty9u+5ujN/s/K1Sb/phspRfgXDRWZ 9oZChaZKJI2FU49/FO/+OCDXzbOaw5PJmWhv/qzB+P/UWgcL+2sDK8CpqPNYJ0QyXAJ6 Y2bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Ad+hImqgLDxypIEINMZpS4Tr/4Mgv7yIFC4Nbt2V9kg=; b=lzhkme+1C5yB58tGYrAQNe58qtT3iXkTgR95c8GqiHTEtO0lfcAwsdDxzYEPeG4t3b hzF+NMwDQIi453EdGQgPUe1841bujAxro4w/1NMoOy9AM0S9UCg0XFKWpNnN1BFCTttt me/LOCNpQr+8EhpT6ERYj+6oj6Uyoy8GwOCsLXhPGjKvlVU/wn99fNPELBtNzT7pvX3+ R7b+P3cBU1z9haecyuKPgL0zWM1CiT8eoO1Lru2CVu6mUZeB/0luybpm73cD18xabAul Rux1lUE04eaWCJtpXDOKmCEUhThwc3e5D4kkZyCvl8T1+kDFEpt43/EEQdXCGGeppOxy B3hg== X-Gm-Message-State: APjAAAWdIjBBRim8jq8PmWcIBjJDKNnilmSzCGI/ZEvWZjWOE77mmWmw 17+1wX+0RSkle3scVMU//zk= X-Google-Smtp-Source: APXvYqxOQ9m72MaS9qncxYQiHkIHq6EHGB9gkSaUGXeDTWotePoS+TGDokUWUtCHpKn4SSzGsUSXEg== X-Received: by 2002:ae9:eb94:: with SMTP id b142mr9178344qkg.450.1573759221143; Thu, 14 Nov 2019 11:20:21 -0800 (PST) Received: from localhost ([2620:10d:c091:500::2:69f2]) by smtp.gmail.com with ESMTPSA id h25sm2893772qka.117.2019.11.14.11.20.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 11:20:20 -0800 (PST) Date: Thu, 14 Nov 2019 11:20:18 -0800 From: Tejun Heo To: Michal Hocko Cc: Roman Gushchin , Michal =?iso-8859-1?Q?Koutn=FD?= , "linux-mm@kvack.org" , Andrew Morton , Johannes Weiner , "linux-kernel@vger.kernel.org" , Kernel Team , "stable@vger.kernel.org" Subject: Re: [PATCH 1/2] mm: memcg: switch to css_tryget() in get_mem_cgroup_from_mm() Message-ID: <20191114192018.GJ4163745@devbig004.ftw2.facebook.com> References: <20191106225131.3543616-1-guro@fb.com> <20191113162934.GF19372@blackbody.suse.cz> <20191113170823.GA12464@castle.DHCP.thefacebook.com> <20191114191657.GN20866@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191114191657.GN20866@dhcp22.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Thu, Nov 14, 2019 at 08:16:57PM +0100, Michal Hocko wrote: > Then what is the point of this function and what about all other users? It is useful for controlling admissions of new userspace visible uses - e.g. a tracepoint shouldn't be allowed to be attached to a cgroup which has already been deleted. We're just using it too liberally. Thanks. -- tejun