From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C64DBC43215 for ; Thu, 14 Nov 2019 18:56:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 99BB520723 for ; Thu, 14 Nov 2019 18:56:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99BB520723 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2AD0F6B0003; Thu, 14 Nov 2019 13:56:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25E306B0005; Thu, 14 Nov 2019 13:56:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 174BA6B0006; Thu, 14 Nov 2019 13:56:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F30AD6B0003 for ; Thu, 14 Nov 2019 13:56:46 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 927A6181AC9C6 for ; Thu, 14 Nov 2019 18:56:46 +0000 (UTC) X-FDA: 76155789612.04.board96_755546c507140 X-HE-Tag: board96_755546c507140 X-Filterd-Recvd-Size: 3442 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Nov 2019 18:56:46 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8F9CAAE12; Thu, 14 Nov 2019 18:56:44 +0000 (UTC) Date: Thu, 14 Nov 2019 19:56:43 +0100 From: Michal Hocko To: Yang Shi Cc: mgorman@techsingularity.net, vbabka@suse.cz, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH] mm: migrate: handle freed page at the first place Message-ID: <20191114185643.GM20866@dhcp22.suse.cz> References: <1573755869-106954-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1573755869-106954-1-git-send-email-yang.shi@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 15-11-19 02:24:29, Yang Shi wrote: > When doing migration if the freed page is met, we just return without > migrating it since it is pointless to migrate a freed page. But, the > current code allocates target page unconditionally before handling freed > page, if the page is freed, the newly allocated will be just freed. It > doesn't make too much sense and is just a waste of time although > migrating freed page is rare. > > So, handle freed page at the before that to avoid unnecessary page > allocation and free. > > Cc: Michal Hocko > Cc: Mel Gorman > Cc: Vlastimil Babka > Signed-off-by: Yang Shi I would be really surprised if this led to any runtime visible effect but I do agree that one less put_page path looks slightly better. For that reason Acked-by: Michal Hocko > --- > v2: * Keep thp migration support check before handling freed page per Michal Hocko > * Fixed the build warning reported by 0-day > > mm/migrate.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 4fe45d1..a8f87cb 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1168,15 +1168,11 @@ static ICE_noinline int unmap_and_move(new_page_t get_new_page, > enum migrate_reason reason) > { > int rc = MIGRATEPAGE_SUCCESS; > - struct page *newpage; > + struct page *newpage = NULL; > > if (!thp_migration_supported() && PageTransHuge(page)) > return -ENOMEM; > > - newpage = get_new_page(page, private); > - if (!newpage) > - return -ENOMEM; > - > if (page_count(page) == 1) { > /* page was freed from under us. So we are done. */ > ClearPageActive(page); > @@ -1187,13 +1183,13 @@ static ICE_noinline int unmap_and_move(new_page_t get_new_page, > __ClearPageIsolated(page); > unlock_page(page); > } > - if (put_new_page) > - put_new_page(newpage, private); > - else > - put_page(newpage); > goto out; > } > > + newpage = get_new_page(page, private); > + if (!newpage) > + return -ENOMEM; > + > rc = __unmap_and_move(page, newpage, force, mode); > if (rc == MIGRATEPAGE_SUCCESS) > set_page_owner_migrate_reason(newpage, reason); > -- > 1.8.3.1 > -- Michal Hocko SUSE Labs