From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 669F0C432C3 for ; Thu, 14 Nov 2019 17:14:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 33A03206F4 for ; Thu, 14 Nov 2019 17:14:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33A03206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DA96C6B0003; Thu, 14 Nov 2019 12:14:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D30F06B0005; Thu, 14 Nov 2019 12:14:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C21066B0006; Thu, 14 Nov 2019 12:14:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id A5A996B0003 for ; Thu, 14 Nov 2019 12:14:46 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 647F3181AEF1A for ; Thu, 14 Nov 2019 17:14:46 +0000 (UTC) X-FDA: 76155532572.24.bee53_63d5283c79b4d X-HE-Tag: bee53_63d5283c79b4d X-Filterd-Recvd-Size: 1628 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Nov 2019 17:14:45 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B100CACF1; Thu, 14 Nov 2019 17:14:44 +0000 (UTC) Date: Thu, 14 Nov 2019 18:14:43 +0100 From: Joerg Roedel To: Shile Zhang Cc: Michal Hocko , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: Fix regression caused by needless vmalloc_sync_all() Message-ID: <20191114171443.GB21753@suse.de> References: <20191113095530.228959-1-shile.zhang@linux.alibaba.com> <20191114135641.GA1356@dhcp22.suse.cz> <83a39694-373b-da16-3be1-22108ace0107@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83a39694-373b-da16-3be1-22108ace0107@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 14, 2019 at 10:40:22PM +0800, Shile Zhang wrote: > Could you please help to recall the original issue you encountered before? The original issue was data corruption because old mappings did not get removed from the vmalloc area, and thus also new mappings did not get faulted in. So depending on the page-table currently loaded one vmalloc/ioremap area pointed to different (often already freed or re-used) memory and caused the corruption. Regards, Joerg