From: Joerg Roedel <jroedel@suse.de>
To: Shile Zhang <shile.zhang@linux.alibaba.com>
Cc: Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmalloc: Fix regression caused by needless vmalloc_sync_all()
Date: Thu, 14 Nov 2019 18:14:43 +0100 [thread overview]
Message-ID: <20191114171443.GB21753@suse.de> (raw)
In-Reply-To: <83a39694-373b-da16-3be1-22108ace0107@linux.alibaba.com>
On Thu, Nov 14, 2019 at 10:40:22PM +0800, Shile Zhang wrote:
> Could you please help to recall the original issue you encountered before?
The original issue was data corruption because old mappings did not get
removed from the vmalloc area, and thus also new mappings did not get
faulted in. So depending on the page-table currently loaded one
vmalloc/ioremap area pointed to different (often already freed or
re-used) memory and caused the corruption.
Regards,
Joerg
next prev parent reply other threads:[~2019-11-14 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 9:55 Shile Zhang
2019-11-13 15:17 ` Qian Cai
2019-11-13 21:12 ` Andrew Morton
2019-11-14 0:54 ` Shile Zhang
2019-11-14 13:56 ` Michal Hocko
2019-11-14 14:40 ` Shile Zhang
2019-11-14 17:14 ` Joerg Roedel [this message]
2019-11-14 17:12 ` Joerg Roedel
2019-11-15 0:01 ` Andrew Morton
2019-11-15 8:38 ` Borislav Petkov
2019-11-15 23:37 ` Andrew Morton
2019-11-16 17:38 ` Borislav Petkov
2019-11-15 1:06 ` Shile Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114171443.GB21753@suse.de \
--to=jroedel@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shile.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox