From: Joerg Roedel <jroedel@suse.de>
To: Shile Zhang <shile.zhang@linux.alibaba.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] mm/vmalloc: Fix regression caused by needless vmalloc_sync_all()
Date: Thu, 14 Nov 2019 18:12:31 +0100 [thread overview]
Message-ID: <20191114171231.GA21753@suse.de> (raw)
In-Reply-To: <20191113095530.228959-1-shile.zhang@linux.alibaba.com>
On Wed, Nov 13, 2019 at 05:55:30PM +0800, Shile Zhang wrote:
> +#if defined(CONFIG_X86_32) && defined(CONFIG_X86_PAE)
> /*
> * First make sure the mappings are removed from all page-tables
> * before they are freed.
> + *
> + * This is only needed on x86-32 with !SHARED_KERNEL_PMD, which is
> + * the case on a PAE kernel with PTI enabled.
> */
> - vmalloc_sync_all();
> + if (!SHARED_KERNEL_PMD && boot_cpu_has(X86_FEATURE_PTI))
> + vmalloc_sync_all();
> +#endif
I already submitted another fix for this quite some time ago:
https://lore.kernel.org/lkml/20191009124418.8286-1-joro@8bytes.org/
Regards,
Joerg
next prev parent reply other threads:[~2019-11-14 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 9:55 Shile Zhang
2019-11-13 15:17 ` Qian Cai
2019-11-13 21:12 ` Andrew Morton
2019-11-14 0:54 ` Shile Zhang
2019-11-14 13:56 ` Michal Hocko
2019-11-14 14:40 ` Shile Zhang
2019-11-14 17:14 ` Joerg Roedel
2019-11-14 17:12 ` Joerg Roedel [this message]
2019-11-15 0:01 ` Andrew Morton
2019-11-15 8:38 ` Borislav Petkov
2019-11-15 23:37 ` Andrew Morton
2019-11-16 17:38 ` Borislav Petkov
2019-11-15 1:06 ` Shile Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114171231.GA21753@suse.de \
--to=jroedel@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shile.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox