From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: jhubbard@nvidia.com, "Jan Kara" <jack@suse.cz>,
"Christoph Hellwig" <hch@lst.de>,
"Ira Weiny" <ira.weiny@intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2] mm: Cleanup __put_devmap_managed_page() vs ->page_free()
Date: Thu, 14 Nov 2019 13:32:37 +0100 [thread overview]
Message-ID: <20191114123237.GA31940@lst.de> (raw)
In-Reply-To: <157371938291.3055029.12105459405251950438.stgit@dwillia2-desk3.amr.corp.intel.com>
On Thu, Nov 14, 2019 at 12:20:13AM -0800, Dan Williams wrote:
> + if (count > 1) {
> + /* still busy */
> + return;
> + } else if (count == 0) {
> + /* only triggered by the dev_pagemap shutdown path */
> + __put_page(page);
> + return;
> + } else if (!is_device_private_page(page)) {
> + /* notify page idle for dax */
> + wake_up_var(&page->_refcount);
> + return;
> + }
No need for an else after a return.
prev parent reply other threads:[~2019-11-14 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 8:20 Dan Williams
2019-11-14 12:32 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114123237.GA31940@lst.de \
--to=hch@lst.de \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox