From: Mike Rapoport <rppt@linux.ibm.com>
To: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, Cao jin <caoj.fnst@cn.fujitsu.com>
Subject: Re: [PATCH] mm/memblock: Correct doc for function
Date: Wed, 13 Nov 2019 11:33:37 +0100 [thread overview]
Message-ID: <20191113103336.GB28740@linux.ibm.com> (raw)
In-Reply-To: <20191113051822.3296-1-ruansy.fnst@cn.fujitsu.com>
On Wed, Nov 13, 2019 at 01:18:22PM +0800, Shiyang Ruan wrote:
> From: Cao jin <caoj.fnst@cn.fujitsu.com>
>
> Change "max_addr" to "end" for less confusion
> in memblock_alloc_range_nid comments.
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> mm/memblock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Suppose this still goes to Andrew's -mm.
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index ceb6761f526d..203ed317551b 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -1321,7 +1321,7 @@ __next_mem_pfn_range_in_zone(u64 *idx, struct zone *zone,
> * @nid: nid of the free area to find, %NUMA_NO_NODE for any node
> *
> * The allocation is performed from memory region limited by
> - * memblock.current_limit if @max_addr == %MEMBLOCK_ALLOC_ACCESSIBLE.
> + * memblock.current_limit if @end == %MEMBLOCK_ALLOC_ACCESSIBLE.
> *
> * If the specified node can not hold the requested memory the
> * allocation falls back to any node in the system
> --
> 2.21.0
>
>
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2019-11-13 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 5:18 Shiyang Ruan
2019-11-13 10:33 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113103336.GB28740@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ruansy.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox