* [PATCH v2] mm/debug: __dump_page() prints an extra line
@ 2019-11-11 22:55 Ralph Campbell
2019-11-12 19:52 ` Jerome Glisse
0 siblings, 1 reply; 2+ messages in thread
From: Ralph Campbell @ 2019-11-11 22:55 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, linux-kernel, Ralph Campbell
When dumping struct page information, __dump_page() prints the page type
with a trailing blank followed by the page flags on a separate line:
anon
flags: 0x100000000090034(uptodate|lru|active|head|swapbacked)
Fix this by using pr_cont() instead of pr_warn() to get a single line:
anon flags: 0x100000000090034(uptodate|lru|active|head|swapbacked)
Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
---
v1 -> v2:
Oops, fix the subject line.
mm/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/debug.c b/mm/debug.c
index 8345bb6e4769..752c78721ea0 100644
--- a/mm/debug.c
+++ b/mm/debug.c
@@ -87,7 +87,7 @@ void __dump_page(struct page *page, const char *reason)
}
BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) != __NR_PAGEFLAGS + 1);
- pr_warn("flags: %#lx(%pGp)\n", page->flags, &page->flags);
+ pr_cont("flags: %#lx(%pGp)\n", page->flags, &page->flags);
hex_only:
print_hex_dump(KERN_WARNING, "raw: ", DUMP_PREFIX_NONE, 32,
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] mm/debug: __dump_page() prints an extra line
2019-11-11 22:55 [PATCH v2] mm/debug: __dump_page() prints an extra line Ralph Campbell
@ 2019-11-12 19:52 ` Jerome Glisse
0 siblings, 0 replies; 2+ messages in thread
From: Jerome Glisse @ 2019-11-12 19:52 UTC (permalink / raw)
To: Ralph Campbell; +Cc: Andrew Morton, linux-mm, linux-kernel
On Mon, Nov 11, 2019 at 02:55:59PM -0800, Ralph Campbell wrote:
> When dumping struct page information, __dump_page() prints the page type
> with a trailing blank followed by the page flags on a separate line:
>
> anon
> flags: 0x100000000090034(uptodate|lru|active|head|swapbacked)
>
> Fix this by using pr_cont() instead of pr_warn() to get a single line:
>
> anon flags: 0x100000000090034(uptodate|lru|active|head|swapbacked)
>
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
> ---
>
> v1 -> v2:
> Oops, fix the subject line.
>
> mm/debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/debug.c b/mm/debug.c
> index 8345bb6e4769..752c78721ea0 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -87,7 +87,7 @@ void __dump_page(struct page *page, const char *reason)
> }
> BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) != __NR_PAGEFLAGS + 1);
>
> - pr_warn("flags: %#lx(%pGp)\n", page->flags, &page->flags);
> + pr_cont("flags: %#lx(%pGp)\n", page->flags, &page->flags);
>
> hex_only:
> print_hex_dump(KERN_WARNING, "raw: ", DUMP_PREFIX_NONE, 32,
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-12 19:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 22:55 [PATCH v2] mm/debug: __dump_page() prints an extra line Ralph Campbell
2019-11-12 19:52 ` Jerome Glisse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox