From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED417C43331 for ; Tue, 12 Nov 2019 15:19:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 909D721872 for ; Tue, 12 Nov 2019 15:19:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 909D721872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0263A6B0003; Tue, 12 Nov 2019 10:19:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3EB96B0005; Tue, 12 Nov 2019 10:19:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7BBA6B0006; Tue, 12 Nov 2019 10:19:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0094.hostedemail.com [216.40.44.94]) by kanga.kvack.org (Postfix) with ESMTP id D218C6B0003 for ; Tue, 12 Nov 2019 10:19:00 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 8E7B4181AEF1A for ; Tue, 12 Nov 2019 15:19:00 +0000 (UTC) X-FDA: 76147983240.27.boys75_88cbd8edbbc38 X-HE-Tag: boys75_88cbd8edbbc38 X-Filterd-Recvd-Size: 2226 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Nov 2019 15:18:59 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 02B8368BE1; Tue, 12 Nov 2019 16:18:57 +0100 (CET) Date: Tue, 12 Nov 2019 16:18:56 +0100 From: Christoph Hellwig To: Ralph Campbell Cc: Jerome Glisse , John Hubbard , Christoph Hellwig , Jason Gunthorpe , Shuah Khan , linux-rdma@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 1/2] mm/hmm: make full use of walk_page_range() Message-ID: <20191112151856.GB12550@lst.de> References: <20191104222141.5173-1-rcampbell@nvidia.com> <20191104222141.5173-2-rcampbell@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191104222141.5173-2-rcampbell@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Looks good, Reviewed-by: Christoph Hellwig Although we could clean this up a tidbit more by removing the start variable: diff --git a/mm/hmm.c b/mm/hmm.c index d4984a08ed9b..b5b1ed646c2f 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -667,10 +667,9 @@ static const struct mm_walk_ops hmm_walk_ops = { */ long hmm_range_fault(struct hmm_range *range, unsigned int flags) { - unsigned long start = range->start; struct hmm_vma_walk hmm_vma_walk = { .range = range, - .last = start, + .last = range->start, .flags = flags, }; struct mm_struct *mm = range->notifier->mm; @@ -682,9 +681,8 @@ long hmm_range_fault(struct hmm_range *range, unsigned int flags) /* If range is no longer valid force retry. */ if (mmu_range_check_retry(range->notifier, range->notifier_seq)) return -EBUSY; - ret = walk_page_range(mm, start, range->end, &hmm_walk_ops, - &hmm_vma_walk); - start = hmm_vma_walk.last; + ret = walk_page_range(mm, hmm_vma_walk.last, range->end, + &hmm_walk_ops, &hmm_vma_walk); } while (ret == -EBUSY); if (ret)