From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA7D6C43331 for ; Tue, 12 Nov 2019 10:22:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A9616206B6 for ; Tue, 12 Nov 2019 10:22:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="E8eucXx4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9616206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4AE6E6B0005; Tue, 12 Nov 2019 05:22:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 45FC26B0006; Tue, 12 Nov 2019 05:22:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34D176B0007; Tue, 12 Nov 2019 05:22:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 193606B0005 for ; Tue, 12 Nov 2019 05:22:03 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id BAE1882499A8 for ; Tue, 12 Nov 2019 10:22:02 +0000 (UTC) X-FDA: 76147234884.28.boats35_11d08448ea053 X-HE-Tag: boats35_11d08448ea053 X-Filterd-Recvd-Size: 2901 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Nov 2019 10:22:02 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E001D206B6; Tue, 12 Nov 2019 10:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573554121; bh=2OfJVEYOOimgK1GNHbcVt6Iqyx+qpcdOc+WEbAqGzoc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E8eucXx4phR6rskbWLG8kTXLs4bKCY4YBYw77GdoYduiOG7/8MPojM5UReD7LANvq 25laE0SeJmLlgdp+4R9icU8ysfRQORQww7d30mYsOSdUnU+Fgt/RlBr+K9Cde1R07A 3o0cLQYbzDiDP5K46MF3usnEgzBklklziQboWcU8= Date: Tue, 12 Nov 2019 11:21:58 +0100 From: Greg Kroah-Hartman To: Mel Gorman Cc: kbuild-all@lists.01.org, Andrew Morton , Linux Memory Management List Subject: Re: [linux-stable-rc:linux-4.4.y 9983/9999] mm/page_alloc.c:2024:2: warning: ISO C90 forbids mixed declarations and code Message-ID: <20191112102158.GB1271102@kroah.com> References: <201911120240.kewQARuu%lkp@intel.com> <20191112085619.GB28938@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112085619.GB28938@suse.de> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 12, 2019 at 08:56:20AM +0000, Mel Gorman wrote: > On Tue, Nov 12, 2019 at 02:27:55AM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y > > head: 56cfa226aa2348915cd4ced0b72542dc35ca2467 > > commit: df82285ab4b974f2040f31dbabdd11e055a282c2 [9983/9999] mm, meminit: recalculate pcpu batch and high limits after init completes > > config: i386-defconfig (attached as .config) > > compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 > > reproduce: > > git checkout df82285ab4b974f2040f31dbabdd11e055a282c2 > > # save the attached .config to linux build tree > > make ARCH=i386 > > > > If you fix the issue, kindly add following tag > > Reported-by: kbuild test robot > > > > All warnings (new ones prefixed by >>): > > > > mm/page_alloc.c: In function 'drain_all_pages': > > >> mm/page_alloc.c:2024:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] > > static cpumask_t cpus_with_pcps; > > ^~~~~~ > > > > Greg, > > It's probably best to drop this patch from 4.4-stable for now. while in > theory the 4.4 kernel is affected, it hasn't been proven and the backport > was not properly evaluated in terms of correctness. Already gone! :)