From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B5E6C43331 for ; Tue, 12 Nov 2019 08:56:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4C52121783 for ; Tue, 12 Nov 2019 08:56:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C52121783 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A94026B0003; Tue, 12 Nov 2019 03:56:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A44476B0005; Tue, 12 Nov 2019 03:56:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 980DC6B0006; Tue, 12 Nov 2019 03:56:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 86DF76B0003 for ; Tue, 12 Nov 2019 03:56:24 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 44992824999B for ; Tue, 12 Nov 2019 08:56:24 +0000 (UTC) X-FDA: 76147019088.20.able52_8f2989a7bd746 X-HE-Tag: able52_8f2989a7bd746 X-Filterd-Recvd-Size: 2283 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Nov 2019 08:56:23 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 02D83AC4D; Tue, 12 Nov 2019 08:56:21 +0000 (UTC) Date: Tue, 12 Nov 2019 08:56:20 +0000 From: Mel Gorman To: Greg Kroah-Hartman Cc: kbuild-all@lists.01.org, Andrew Morton , Linux Memory Management List Subject: Re: [linux-stable-rc:linux-4.4.y 9983/9999] mm/page_alloc.c:2024:2: warning: ISO C90 forbids mixed declarations and code Message-ID: <20191112085619.GB28938@suse.de> References: <201911120240.kewQARuu%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <201911120240.kewQARuu%lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 12, 2019 at 02:27:55AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y > head: 56cfa226aa2348915cd4ced0b72542dc35ca2467 > commit: df82285ab4b974f2040f31dbabdd11e055a282c2 [9983/9999] mm, meminit: recalculate pcpu batch and high limits after init completes > config: i386-defconfig (attached as .config) > compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 > reproduce: > git checkout df82285ab4b974f2040f31dbabdd11e055a282c2 > # save the attached .config to linux build tree > make ARCH=i386 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All warnings (new ones prefixed by >>): > > mm/page_alloc.c: In function 'drain_all_pages': > >> mm/page_alloc.c:2024:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] > static cpumask_t cpus_with_pcps; > ^~~~~~ > Greg, It's probably best to drop this patch from 4.4-stable for now. while in theory the 4.4 kernel is affected, it hasn't been proven and the backport was not properly evaluated in terms of correctness. -- Mel Gorman SUSE Labs