From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2E9C43331 for ; Tue, 12 Nov 2019 06:29:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9E44F2067B for ; Tue, 12 Nov 2019 06:29:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CmNQS9o0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E44F2067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 200276B0003; Tue, 12 Nov 2019 01:29:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18AE56B0005; Tue, 12 Nov 2019 01:29:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0299B6B0006; Tue, 12 Nov 2019 01:29:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id DD22C6B0003 for ; Tue, 12 Nov 2019 01:29:57 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 8252B180AD801 for ; Tue, 12 Nov 2019 06:29:57 +0000 (UTC) X-FDA: 76146650034.24.kick34_1ca82a8c03f0c X-HE-Tag: kick34_1ca82a8c03f0c X-Filterd-Recvd-Size: 5652 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Nov 2019 06:29:56 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id w9so10348595wrr.0 for ; Mon, 11 Nov 2019 22:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lAYMmo1eJk0nu5Pp/QFztO4nECppTXXyiwDmyLApAMU=; b=CmNQS9o057m02iB3aVZCvD9IKuX8qvcKJgJUgyo4KExtj2bJGSViNfCsIbt5SiuwMO vuoCblpkhQtIhImySY2l9xgcSalma2cLx/gmbDWtxOG+KeWeZqQREyCEiZtz2MaeiTEY RldTTXX6x5mGp2gTJOMJKKnH3ErtuhTGJVb/oxnV4qflBhEKc0iGhFu9X9Z6Ewwj/nv7 RJ+bk94WWdoFyERGDm1828mxsXI6cvzgXYdmifbVY3rPGuNlfG2Jz7tz9D0yBEL7amvI N9XaeSRhLvOl3rh+bmOKbDc4uYMU01us4xdrDKX0UOdp1yr6ys5I9p7y6gCnhALJgHcw WXUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=lAYMmo1eJk0nu5Pp/QFztO4nECppTXXyiwDmyLApAMU=; b=NnXWE/caNjL/U2b4HOoj1LAk2UfBJbRqnX6u2EwZjHnxsrYbvyw1/12aCv5D5TzfpY ArZDNhogGAgVSMUi5aJSItmErRBCoM2vGg+APZo95ll7o2WX3PmvMyUG1x5ZLcaxmCv2 c0Ao04ob1MbTp6OWrNUl/BtK6p/1iGPc5TeuVeSEQXTnCrizaTh5HFpRxNRYUzq8xQaR 5Zp+Qj4upOwXSO4aZQd58pPO+G0kvMWzyrXTd53cm4D/EO4Ha4AcPXhtXwl1FlTxBot+ sy+/jC+722HWbZYgJlG+NvsWSR3KQSbDrQ8X582+sJZ71PAOibD/T0SW2tip5ocHnNO9 Vynw== X-Gm-Message-State: APjAAAXgvaidyHNB7xja/RKWbE5pJ/u2gZYW2WTXyBCocMvN1KexwDxx dJg/Z1OCfvC2j20TF4MVcRY= X-Google-Smtp-Source: APXvYqwg7II6op5rkcQCA+kVGqp8JW9qmm3wOv2otknPBBGlW4hCTPNNQNQ0ueZUnows/DjxDY46Ng== X-Received: by 2002:adf:ab4c:: with SMTP id r12mr23079230wrc.3.1573540195668; Mon, 11 Nov 2019 22:29:55 -0800 (PST) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id 19sm40418570wrc.47.2019.11.11.22.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 22:29:54 -0800 (PST) Date: Tue, 12 Nov 2019 07:29:51 +0100 From: Ingo Molnar To: Anshuman Khandual Cc: linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Christophe Leroy , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V9] mm/debug: Add tests validating architecture page table helpers Message-ID: <20191112062951.GA100264@gmail.com> References: <1573532326-24084-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1573532326-24084-1-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Anshuman Khandual wrote: > +config DEBUG_VM_PGTABLE > + bool "Debug arch page table for semantics compliance" > + depends on MMU > + depends on DEBUG_VM > + depends on ARCH_HAS_DEBUG_VM_PGTABLE > + help > + This option provides a debug method which can be used to test > + architecture page table helper functions on various platforms in > + verifying if they comply with expected generic MM semantics. This > + will help architecture code in making sure that any changes or > + new additions of these helpers still conform to expected > + semantics of the generic MM. > + > + If unsure, say N. Since CONFIG_DEBUG_VM is generally disabled in distro kernel packages, why not make this 'default y' to maximize testing coverage? The code size increase should be minimal, and DEBUG_VM increases size anyway. Other than that this looks good to me: Reviewed-by: Ingo Molnar Thanks, Ingo