From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A17E1C17441 for ; Mon, 11 Nov 2019 14:53:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6651B21E6F for ; Mon, 11 Nov 2019 14:53:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6651B21E6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1619A6B0006; Mon, 11 Nov 2019 09:53:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 112746B0007; Mon, 11 Nov 2019 09:53:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04EC76B0008; Mon, 11 Nov 2019 09:53:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id E3B236B0006 for ; Mon, 11 Nov 2019 09:53:57 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 8300B824999B for ; Mon, 11 Nov 2019 14:53:57 +0000 (UTC) X-FDA: 76144291314.06.rod27_56696fc2453f X-HE-Tag: rod27_56696fc2453f X-Filterd-Recvd-Size: 3118 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Nov 2019 14:53:56 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C2ACDB11B; Mon, 11 Nov 2019 14:53:54 +0000 (UTC) Date: Mon, 11 Nov 2019 15:53:54 +0100 From: Michal Hocko To: Chris Down Cc: Andrew Morton , Johannes Weiner , Tejun Heo , Roman Gushchin , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH] docs: cgroup: mm: Document why inactive_X + active_X may not equal X Message-ID: <20191111145354.GN1396@dhcp22.suse.cz> References: <20191111144958.GA11914@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191111144958.GA11914@chrisdown.name> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 11-11-19 14:49:58, Chris Down wrote: > This has confused a significant number of people using cgroups inside > Facebook, and some of those outside as well judging by posts like > this[0] (although it's not a problem unique to cgroup v2). If shmem > handling in particular becomes more coherent at some point in the future > -- although that seems unlikely now -- we can change the wording here. > > [0]: https://unix.stackexchange.com/q/525092/10762 > > Signed-off-by: Chris Down > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Tejun Heo > Cc: Roman Gushchin > Cc: Michal Hocko > Cc: linux-kernel@vger.kernel.org > Cc: cgroups@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: kernel-team@fb.com Acked-by: Michal Hocko > --- > Documentation/admin-guide/cgroup-v2.rst | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 0704552ed94f..0636bcb60b5a 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -1289,7 +1289,12 @@ PAGE_SIZE multiple when read back. > inactive_anon, active_anon, inactive_file, active_file, unevictable > Amount of memory, swap-backed and filesystem-backed, > on the internal memory management lists used by the > - page reclaim algorithm > + page reclaim algorithm. > + > + As these represent internal list state (eg. shmem pages are on anon > + memory management lists), inactive_foo + active_foo may not be equal to and anon will move to file list after MADV_FREE. > + the value for the foo counter, since the foo counter is type-based, not > + list-based. > > slab_reclaimable > Part of "slab" that might be reclaimed, such as > -- > 2.24.0 -- Michal Hocko SUSE Labs