From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE905C43331 for ; Mon, 11 Nov 2019 13:14:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9E7C52190F for ; Mon, 11 Nov 2019 13:14:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="Hbv7vTAJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E7C52190F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3AAAA6B0006; Mon, 11 Nov 2019 08:14:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35AAF6B0007; Mon, 11 Nov 2019 08:14:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26FF66B0008; Mon, 11 Nov 2019 08:14:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 142AE6B0006 for ; Mon, 11 Nov 2019 08:14:31 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id A4DD0180AD822 for ; Mon, 11 Nov 2019 13:14:30 +0000 (UTC) X-FDA: 76144040700.23.paper32_a3a2d8690607 X-HE-Tag: paper32_a3a2d8690607 X-Filterd-Recvd-Size: 3337 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Nov 2019 13:14:30 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id 8so13188122wmo.0 for ; Mon, 11 Nov 2019 05:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vSSh3GLhg1vsDC2+/ekTGoEZx+xBL7fSSkyIjDBus0Y=; b=Hbv7vTAJaj3aLmwp1G2ep546uZEGDBhi+No53kbAa6wWPB2FUuSzQQNt4SsHuEN8GQ HOkbiVLgICe1ia9awIe0L/ZyaHt8V5FNGkmWEjYcJ3MwIay/64IGOcm/mM1XU2XSBZHg +NC8P6rEpo8CNdNh8I7JHCXqgbNRUvoRrrLk8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vSSh3GLhg1vsDC2+/ekTGoEZx+xBL7fSSkyIjDBus0Y=; b=I/Ob6xQWdqFLf9XmEiRnAPpy9HS2nmeoq0yma8V2jJINeDtKq4VOA632PA0dRDt65L Z0bXedWtkeUFVM4sjqL12TCM/TaG/5oFo5YXV7SgNnJDcVuii8kkxG/2MSiA17d1NyUH mRAU7gPmYeDiSRHBETiny8KzJA8qLJclNcNrlIgNJlHe5Rj28jrJijwsu2OxWKFsDwVI tBkVdff4sov/hAhd1SuaiwsrcYogXPGJINMdvAiSctHauf89EA5pVY39I3m0UJsi6CgR 9C2NjIGwJUOtP878dCwgsNZAjlOnBX54TXD1dgUtQN83QjPd602QcvawlLJZo4fdU5JR FmOA== X-Gm-Message-State: APjAAAXZVGyyu06MelSTyZrXuEzOO90/U8FVooI3x/Lhd4HrMnJltPLP +svtm+aSfw1vBDC7MKNJArAjXsnDO0M= X-Google-Smtp-Source: APXvYqyvhczbf2LwFCvdR3MOfU8SLKVDbuWW3StMeBDBW7wyn9GfgKvdjUBLmTzPLz1EDYVikGjX4g== X-Received: by 2002:a1c:60d7:: with SMTP id u206mr21398439wmb.101.1573478068839; Mon, 11 Nov 2019 05:14:28 -0800 (PST) Received: from localhost ([2a01:4b00:8432:8a00:fa59:71ff:fe7e:8d21]) by smtp.gmail.com with ESMTPSA id u13sm6150007wmm.45.2019.11.11.05.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 05:14:28 -0800 (PST) Date: Mon, 11 Nov 2019 13:14:27 +0000 From: Chris Down To: Qian Cai Cc: akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, guro@fb.com, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm/vmscan: fix an undefined behavior for zone id Message-ID: <20191111131427.GB891635@chrisdown.name> References: <20191108204407.1435-1-cai@lca.pw> <64E60F6F-7582-427B-8DD5-EF97B1656F5A@lca.pw> <20191111130516.GA891635@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191111130516.GA891635@chrisdown.name> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.004839, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Chris Down writes: >Ah, I just saw this in my local checkout and thought it was from my >changes, until I saw it's also on clean mmots checkout. Thanks for the >fixup! Also, does this mean we should change callers that may pass through zone_idx=MAX_NR_ZONES to become MAX_NR_ZONES-1 in a separate commit, then remove this interim fixup? I'm worried otherwise we might paper over real issues in future.