From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDCE6C5DF60 for ; Fri, 8 Nov 2019 14:53:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 815A9222C4 for ; Fri, 8 Nov 2019 14:53:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="CnUhcgt/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 815A9222C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0EBB86B0005; Fri, 8 Nov 2019 09:53:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09BF76B0006; Fri, 8 Nov 2019 09:53:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFCDA6B0007; Fri, 8 Nov 2019 09:53:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id D76C06B0005 for ; Fri, 8 Nov 2019 09:53:04 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 865E14425 for ; Fri, 8 Nov 2019 14:53:04 +0000 (UTC) X-FDA: 76133402688.10.cloth10_72194cf05e51f X-HE-Tag: cloth10_72194cf05e51f X-Filterd-Recvd-Size: 5301 Received: from mail-qv1-f66.google.com (mail-qv1-f66.google.com [209.85.219.66]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Fri, 8 Nov 2019 14:53:03 +0000 (UTC) Received: by mail-qv1-f66.google.com with SMTP id n12so2299778qvt.1 for ; Fri, 08 Nov 2019 06:53:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=KbZhp4AkDu7Xm430isAdIZqP2fKWimvIRojP4EOaH94=; b=CnUhcgt/uCiHhFzG5fQwx/7yL/1CG4oXAa5rt7QVxsRyYE9BvjQnSrmpCegteZ6wG6 UdbIqy2G3VBCdlFsOHxs/+U1RPE3dzDODchlcknxyMkLszr7SBFzpBBLTiddH4Tg08Ht mzvu2U3GfPtm+8nhuisFAzAvLGGBD26Rr2qKwRtahR5/cWZ9Dw2546KcysI5+LmkFl4f uw4TZt8ZwEN4pTKLcXSMHSPwzQXJJ83lX+Vu0OBNgSn6qsoG5vEKP04ONdCWloYbp4p+ mbwxr54K0neA//wodYLjyKVnqB2cadeD0Xva/t+JRc+rAwGI6mVj5ESfMeaSIg5DxLSM vL/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=KbZhp4AkDu7Xm430isAdIZqP2fKWimvIRojP4EOaH94=; b=SRJqGUfxvSsvlReromdoMOS4BPtJ0jFZnHf1/xaRKr9iDA37T9SZtOWxQbTS17dcBv APKt5KECQxTasBlo13n9GfvXi4LkLzVr+qkfb6Rk2d2n6/5q12sY8Z7CuUzDp17Q1rlY PhUDlUFG3dbwGWBOcOpMzlV0rQCxN5VnE6Brou7xAnvhDKdXt6Mx1NisH+2ZITirFEMn +tHLBXdloqZHgZYV68UtmA78otaGIZgk5lCmS0RqC52qvOlFcQu7kcWhAgD1lPYx9QUr B+J0PXIJ5wxBrKQMRFNcsefqPangfWDLFTKu4MTJGXQY2BgpOgkOOdVTL85PsQaXv/38 NepQ== X-Gm-Message-State: APjAAAUkQZPt53bHk9bkxAFzB6oKdo3iJdJrcoi1zQ2vkUuuxbXY0Wvk hu7INettk2bXNntc8LehkwP2rg== X-Google-Smtp-Source: APXvYqxZ049SfJ3c2UO0ME4Y6QYpdzEBI6gXk0X7dNRcV8X3z8aw7kr92ScWfx2YoejxONb2FvDR8w== X-Received: by 2002:a05:6214:11f2:: with SMTP id e18mr10122108qvu.86.1573224783191; Fri, 08 Nov 2019 06:53:03 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id o3sm3732759qta.3.2019.11.08.06.53.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Nov 2019 06:53:02 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iT5dF-0003YQ-V5; Fri, 08 Nov 2019 10:53:01 -0400 Date: Fri, 8 Nov 2019 10:53:01 -0400 From: Jason Gunthorpe To: Boris Ostrovsky Cc: "linux-mm@kvack.org" , Jerome Glisse , Ralph Campbell , John Hubbard , "Felix.Kuehling@amd.com" , "linux-rdma@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , Alex Deucher , Ben Skeggs , Christian =?utf-8?B?S8O2bmln?= , David Zhou , Dennis Dalessandro , Juergen Gross , Mike Marciniszyn , Oleksandr Andrushchenko , Petr Cvek , Stefano Stabellini , "nouveau@lists.freedesktop.org" , "xen-devel@lists.xenproject.org" , Christoph Hellwig Subject: Re: [PATCH v2 09/15] xen/gntdev: use mmu_range_notifier_insert Message-ID: <20191108145301.GD10956@ziepe.ca> References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-10-jgg@ziepe.ca> <3938b588-c6c5-3bd1-8ea9-47e4d5b2045c@oracle.com> <20191105023108.GN22766@mellanox.com> <20191107203629.GF6730@ziepe.ca> <4a68acc6-3ce7-e26b-2c98-774867288410@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4a68acc6-3ce7-e26b-2c98-774867288410@oracle.com> User-Agent: Mutt/1.9.4 (2018-02-28) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 07, 2019 at 05:54:52PM -0500, Boris Ostrovsky wrote: > On 11/7/19 3:36 PM, Jason Gunthorpe wrote: > > On Tue, Nov 05, 2019 at 10:16:46AM -0500, Boris Ostrovsky wrote: > > > >>> So, I suppose it can be relaxed to a null test and a WARN_ON that i= t > >>> hasn't changed? > >> You mean > >> > >> if (use_ptemod) { > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(map->vma !=3D vma= ); > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ... > >> > >> > >> Yes, that sounds good. > > I amended my copy of the patch with the above, has this rework shown > > signs of working? >=20 > Yes, it works fine. >=20 > But please don't forget notifier ops initialization. >=20 > With those two changes, >=20 > Reviewed-by: Boris Ostrovsky Thanks, I got both things. I'll forward this toward linux-next and repost a v3=20 Jason