From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A2CC5DF60 for ; Thu, 7 Nov 2019 20:36:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6488420869 for ; Thu, 7 Nov 2019 20:36:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="D3bFpO22" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6488420869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED1A06B0003; Thu, 7 Nov 2019 15:36:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E5A8D6B0006; Thu, 7 Nov 2019 15:36:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFBA96B0007; Thu, 7 Nov 2019 15:36:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B6E1A6B0003 for ; Thu, 7 Nov 2019 15:36:32 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 5245A2C32 for ; Thu, 7 Nov 2019 20:36:32 +0000 (UTC) X-FDA: 76130639424.23.boys99_9051a95efc43c X-HE-Tag: boys99_9051a95efc43c X-Filterd-Recvd-Size: 5209 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Nov 2019 20:36:31 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id u22so3818617qtq.13 for ; Thu, 07 Nov 2019 12:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=71LM+xH1wkNpW127vr6ZxQkFrR5SvDtsBzUQHq660ZY=; b=D3bFpO22vYKzoP0y0kJzENmUIyEWWuBeZdrbWOd1NSHyV6jshwYAek9v0UQlPVNFPm gMM8Mo2Kxc8gRUHzzjxaadcVCTPEcRYvCbAIX8OusFUjw7o9YpFUkiK3RoQQUeow2ms9 eGazhDIo9mJpashFsikQQIbjd6TISyD1pZmFKifpX4Zhcl//XXhGcH3+Zo5Kzt51FlB3 w1yAflYz0ICBGX3upadZlsBXvu1aRMmxOCzSLHPZYss2G0V4O2B7ESmEO3vtegVYkAKW tSKEpqMzverpHSnG3I+axEeI7kQum6AfY8LA3KuUKxqL3srA0wFn9Z1ou/8PeWVKM40a a1yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=71LM+xH1wkNpW127vr6ZxQkFrR5SvDtsBzUQHq660ZY=; b=mt5i7BPXho/UP95z+0wMYrH6uZZZbAJSiDvn6ZyvOZVLdwPFgUW9u7tDoPdmEeXkIp C/PujVnCP+V7rkbL+rTZX09NZLShVf7Ag5777ExeqCvnwDR0jpKFbD0SDd9y+DawOeH5 AntK3jBXMP/cb7QgNgapwsA1ZZwk2w0I10y+6Itcs73qhISb3Z7G9WHeABm3En3sswWA sqo5L2JleFSIOoWbg4wic/Hfal41hdf0wIxyr1JzKRcFK2fjvxfUpOThe0IXZuSzBZ8X dzQEsm+FQjEN/anDkNLRCtOLpAit0raQqnYPgn4hdEJGRG5s+2SXfz3DDoi7zr/ttTRT dnhg== X-Gm-Message-State: APjAAAW4zl3UzE/Zm8+YBBkyppkVd3BHWLMEElYrmypC3nwg0F1JHckY 2HnjE/gQvCwsV4WxsYM4y0PZdA== X-Google-Smtp-Source: APXvYqyNBsBryLeEi7SIRoAPqzH4cK3zfUarxZiwLJPOIp00fgPi4tyHDHRm5q/vs9/sR4SDhwZ/Hw== X-Received: by 2002:ac8:67d9:: with SMTP id r25mr6108730qtp.7.1573158991013; Thu, 07 Nov 2019 12:36:31 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id q17sm2194836qtq.58.2019.11.07.12.36.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Nov 2019 12:36:30 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iSoW5-0000Io-Qj; Thu, 07 Nov 2019 16:36:29 -0400 Date: Thu, 7 Nov 2019 16:36:29 -0400 From: Jason Gunthorpe To: Boris Ostrovsky Cc: "linux-mm@kvack.org" , Jerome Glisse , Ralph Campbell , John Hubbard , "Felix.Kuehling@amd.com" , "linux-rdma@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , Alex Deucher , Ben Skeggs , Christian =?utf-8?B?S8O2bmln?= , David Zhou , Dennis Dalessandro , Juergen Gross , Mike Marciniszyn , Oleksandr Andrushchenko , Petr Cvek , Stefano Stabellini , "nouveau@lists.freedesktop.org" , "xen-devel@lists.xenproject.org" , Christoph Hellwig Subject: Re: [PATCH v2 09/15] xen/gntdev: use mmu_range_notifier_insert Message-ID: <20191107203629.GF6730@ziepe.ca> References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-10-jgg@ziepe.ca> <3938b588-c6c5-3bd1-8ea9-47e4d5b2045c@oracle.com> <20191105023108.GN22766@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 05, 2019 at 10:16:46AM -0500, Boris Ostrovsky wrote: > > So, I suppose it can be relaxed to a null test and a WARN_ON that it > > hasn't changed? >=20 > You mean >=20 > if (use_ptemod) { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(map->vma !=3D vma); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ... >=20 >=20 > Yes, that sounds good. I amended my copy of the patch with the above, has this rework shown signs of working? @@ -436,7 +436,8 @@ static void gntdev_vma_close(struct vm_area_struct *v= ma) struct gntdev_priv *priv =3D file->private_data; =20 pr_debug("gntdev_vma_close %p\n", vma); - if (use_ptemod && map->vma =3D=3D vma) { + if (use_ptemod) { + WARN_ON(map->vma !=3D vma); mmu_range_notifier_remove(&map->notifier); map->vma =3D NULL; } Jason