From: Andrew Morton <akpm@linux-foundation.org>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Tang Chen <tangchen@cn.fujitsu.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Keith Busch <keith.busch@intel.com>, Jiri Olsa <jolsa@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Jani Nikula <jani.nikula@intel.com>,
Nayna Jain <nayna@linux.ibm.com>, Michal Hocko <mhocko@suse.com>,
Oscar Salvador <osalvador@suse.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Dan Williams <dan.j.williams@intel.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>
Subject: Re: [PATCH v3] mm/memory_hotplug: Fix try_offline_node()
Date: Thu, 7 Nov 2019 19:58:45 -0800 [thread overview]
Message-ID: <20191107195845.b0b3921ea146a60d042a8f64@linux-foundation.org> (raw)
In-Reply-To: <51bdb854-a60e-d076-5dde-38481bf4a4b1@redhat.com>
On Thu, 7 Nov 2019 00:14:13 +0100 David Hildenbrand <david@redhat.com> wrote:
> > + /*
> > + * Especially offline memory blocks might not be spanned by the
> > + * node. They will get spanned by the node once they get onlined.
> > + * However, they link to the node in sysfs and can get onlined later.
> > + */
> > + rc = for_each_memory_block(&nid, check_no_memblock_for_node_cb);
> > + if (rc)
> > return;
> > - }
> >
> > if (check_cpu_on_node(pgdat))
> > return;
> >
>
> @Andrew, can you queued this one instead of v1 so we can give this some
> more testing? Thanks!
Sure.
We have a tested-by but no reviewed-by or acked-by :(
Null pointer derefs are unpopular. Should we cc:stable?
next prev parent reply other threads:[~2019-11-08 3:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-02 12:02 David Hildenbrand
2019-11-05 1:20 ` Masayoshi Mizuma
2019-11-05 10:07 ` David Hildenbrand
2019-11-06 23:14 ` David Hildenbrand
2019-11-08 3:58 ` Andrew Morton [this message]
2019-11-16 0:08 ` Andrew Morton
2019-11-16 0:12 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107195845.b0b3921ea146a60d042a8f64@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@intel.com \
--cc=jolsa@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=nayna@linux.ibm.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox