From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 887A1C5DF62 for ; Wed, 6 Nov 2019 09:07:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 36DBB2178F for ; Wed, 6 Nov 2019 09:07:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SDxsxNxz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36DBB2178F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DBDE06B0003; Wed, 6 Nov 2019 04:07:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D45866B0006; Wed, 6 Nov 2019 04:07:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE6706B0007; Wed, 6 Nov 2019 04:07:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id A45CA6B0003 for ; Wed, 6 Nov 2019 04:07:39 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 5F46845A6 for ; Wed, 6 Nov 2019 09:07:39 +0000 (UTC) X-FDA: 76125274638.08.stone19_25ac73cbe7a3a X-HE-Tag: stone19_25ac73cbe7a3a X-Filterd-Recvd-Size: 5514 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Nov 2019 09:07:38 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id p26so18359757pfq.8 for ; Wed, 06 Nov 2019 01:07:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eW1YFA1pYifFQDaA6CSVMtfOl31KdDKXOyioyxRH08I=; b=SDxsxNxzNqUE1q7vyuM9ldx0rKuBaurf1NtuoOGhBxh+Bqh0Ys9cdDhSjWA0vBTpSo ddan7/9NapIKnH9YNKeHyOySB2PuNxONmiPqBt36f+Bdwm9OhwY/kK9ALsbVe/uOH8t+ /uMlhAqqcBEypkU/UlqppTyIlItIoRelMH9InTxN7zKTEaW/LJMUvXsRps7k1WzKdafI A1oRmZJoObNLpxmSvmjWVN83Inlv21HDGRcsl1hJqzyS9CGlUoz5256z1/33dn8YIy2F yBsx0/IiNrVBRaJTLFVNBCw4yPdjE5Zkt5VkYQb9JswLuLDiJ0WUHwy4QuaE6W74ZKVL jrxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eW1YFA1pYifFQDaA6CSVMtfOl31KdDKXOyioyxRH08I=; b=PgN0xd6qTY5SOdbhz77/tCUGQWPGuwKVf5rcL+2u9P3ZunvlRi2UWjN+QiNvz0s2Z7 QIPMxyX79WisFBpfDmlcMuFh8/iwV5i5WZt7jeGMtnUa8/Es9Grcx3dlnJ2TZ1q4hdKN K3pnVSXDsJUYNKi0VZS/kt2qXEEHO6oTYTOaSNxgUq/9l/wP6fanlLlLBzy2b4hWTkMm KV5ln6DJFtFGYw3T89Aont4PvXId9uQdSejd5Muq/xhKT96yBcNEOlGZfqTajgzhACUg xejPlDcnd1n3lZOiGzB4VxRqMLhxG8NgMNq4gUGoNn4IwW8QKYLU2ysEUcibwJcWd8PQ qVjA== X-Gm-Message-State: APjAAAWvWbQui8F3HkUDcQSH3Qk0YxI2KsU7u4ExGP3IJsUqsa0LBLtk 2hW8BCByMqmXh+H1x0Q4O+o= X-Google-Smtp-Source: APXvYqyaWhE5XYnrXQ4MumN0IE2cTVz/aMX05qd6FTKE+bhGCpkN1tTCLsdoKbAgKtWDmzFGnlihmA== X-Received: by 2002:aa7:8e1a:: with SMTP id c26mr297870pfr.151.1573031257724; Wed, 06 Nov 2019 01:07:37 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:250d:e71d:5a0a:9afe]) by smtp.gmail.com with ESMTPSA id fz12sm2012011pjb.15.2019.11.06.01.07.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2019 01:07:36 -0800 (PST) Date: Wed, 6 Nov 2019 18:07:34 +0900 From: Sergey Senozhatsky To: Alexander Potapenko Cc: Sergey Senozhatsky , Petr Mladek , Andrew Morton , Greg Kroah-Hartman , Eric Dumazet , Wolfram Sang , Vegard Nossum , Dmitry Vyukov , Linux Memory Management List , Al Viro , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Dmitry Torokhov , Eric Van Hensbergen , Harry Wentland , Herbert Xu , Ingo Molnar , Jens Axboe , "Martin K . Petersen" , Martin Schwidefsky , "Michael S. Tsirkin" , Michal Simek , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , Theodore Ts'o , Thomas Gleixner , Vasily Gorbik , Ilya Leoshkevich , Mark Rutland , Matthew Wilcox , Randy Dunlap , Andrey Konovalov , Marco Elver Subject: Re: [PATCH RFC v2 18/25] kmsan: call KMSAN hooks where needed Message-ID: <20191106090734.GA178981@google.com> References: <20191030142237.249532-1-glider@google.com> <20191030142237.249532-19-glider@google.com> <20191031114916.ikz3phubs4jqdmnf@pathway.suse.cz> <20191101082639.GA19790@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (19/11/05 15:12), Alexander Potapenko wrote: [..] > > > > + * If any of vscnprintf() arguments is uninitialized, KMSAN will report > > > > + * one or more errors and also probably mark text_len as uninitialized. > > > > + * Initialize |text_len| to prevent the errors from spreading further. > > > > + */ > > > > + text_len = KMSAN_INIT_VALUE(vscnprintf(text, sizeof(textbuf), fmt, > > > > + args)); > > > > Or maybe this can be > > > > text_len = vscnprintf(text, sizeof(textbuf), fmt, args); > > + KMSAN_INIT_VALUE(text_len); > This isn't how KMSAN_INIT_VALUE works. It takes a value that may be > uninitialized and returns the same value marked as initialized. Ah, I see. > Shall I do: > text_len = KMSAN_INIT_VALUE(text_len); > instead? Yes, +1 from me. -ss