From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18EF7C47E49 for ; Wed, 6 Nov 2019 08:28:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C543C2178F for ; Wed, 6 Nov 2019 08:28:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="r03fdaNA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C543C2178F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6ADF46B0003; Wed, 6 Nov 2019 03:28:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65D6B6B0006; Wed, 6 Nov 2019 03:28:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5735D6B0007; Wed, 6 Nov 2019 03:28:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 430E46B0003 for ; Wed, 6 Nov 2019 03:28:48 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id E40AA180AD802 for ; Wed, 6 Nov 2019 08:28:47 +0000 (UTC) X-FDA: 76125176694.02.fowl09_86f50f38ea422 X-HE-Tag: fowl09_86f50f38ea422 X-Filterd-Recvd-Size: 4485 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Nov 2019 08:28:47 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id m6so1193930lfl.3 for ; Wed, 06 Nov 2019 00:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ucyWnZTb08Kz+XLZc748AyyMVAhHeNNS7JX/C/XNmYE=; b=r03fdaNAZ7U381lbC6TcKDfuOFCkCOAQc2krSSfYDLprHpTtU/u007d+9oVtsfX2gq MUwo8WsB6FPqidZCoSZ2gDpqgp7bTh3A07L1SaTHG/dHvva4OwNfXYFJiartQvnu+8Y2 9NNDcEtzAIoMo9uXgo6sGwJXQd/KNmkFsw+eSalOb4CLjaqsyDE21T4ot2u6sZqElzln CANEFS6cfSzYx7fvtBkGLBJkF7jL9Xyn/gTk3TFNuHcU7Id6cDXPcrK4Nk8zbO5nE+ZQ xD2fycjkVdRJER074Phslq5Y47YdY9DR2Z5KFeqBXseM01XpUV8inks4j4tZLw6pVFsM 2sIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ucyWnZTb08Kz+XLZc748AyyMVAhHeNNS7JX/C/XNmYE=; b=eOYifJYvLwC/3llqSZiMJiEnZsE4C39rW6bBEncx6xHJx0qepttETi0f3OmpPSm7lz M5AROFioory71NbaNR6P6JWy4tt7c08CRX9Pr+JFeqoFLAf5IeYaRR1pHhTzs4v2K6t6 mVaNRlkIo2VSgaTYJyovFSg5PlgZFZHNI7vbbqgKqjLBtvJxbwQqwqs1PQsHyKYdfVCZ SuCobTPqB8XezXvhu8C6MvjiSDA+SP67DRnvwOET4X36rOOv1EPbNTEsOn7shbmfF1fh aH8j+NQWjNWOWxQYBkHOi3Nhku1cPxBbyWasW3+zSgmsN9dhIQn4+5cqIu1d0zdVfHld 3KoQ== X-Gm-Message-State: APjAAAUO324avslys7CHbeItLggx4ezw7lCvVczY8cQmviYdzBvm4cn8 6cH9LzRtfOaodWN1zBhDM0rPejeUw4KPIw== X-Google-Smtp-Source: APXvYqye1zBZCOxIERc/ngm2M5//JQap3QWc+gDHjwKvjW1783JV9LVXNckqA6BHBwAsuXwfs0rSsg== X-Received: by 2002:a19:5e0e:: with SMTP id s14mr9273100lfb.30.1573028925442; Wed, 06 Nov 2019 00:28:45 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id c14sm10241986ljd.3.2019.11.06.00.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2019 00:28:44 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 6BAA9100918; Wed, 6 Nov 2019 11:28:48 +0300 (+03) Date: Wed, 6 Nov 2019 11:28:48 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: rmap: use VM_BUG_ON() in __page_check_anon_rmap() Message-ID: <20191106082848.eukf2jnjqxlvxgnx@box> References: <1572973416-18532-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572973416-18532-1-git-send-email-yang.shi@linux.alibaba.com> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 06, 2019 at 01:03:36AM +0800, Yang Shi wrote: > The __page_check_anon_rmap() just calls two BUG_ON()s protected by > CONFIG_DEBUG_VM, the #ifdef could be eliminated by using VM_BUG_ON(). > > Signed-off-by: Yang Shi > --- > mm/rmap.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index d17cbf3..39178eb 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1055,7 +1055,6 @@ static void __page_set_anon_rmap(struct page *page, > static void __page_check_anon_rmap(struct page *page, > struct vm_area_struct *vma, unsigned long address) > { > -#ifdef CONFIG_DEBUG_VM > /* > * The page's anon-rmap details (mapping and index) are guaranteed to > * be set up correctly at this point. > @@ -1068,9 +1067,8 @@ static void __page_check_anon_rmap(struct page *page, > * are initially only visible via the pagetables, and the pte is locked > * over the call to page_add_new_anon_rmap. > */ > - BUG_ON(page_anon_vma(page)->root != vma->anon_vma->root); > - BUG_ON(page_to_pgoff(page) != linear_page_index(vma, address)); > -#endif > + VM_BUG_ON(page_anon_vma(page)->root != vma->anon_vma->root); > + VM_BUG_ON(page_to_pgoff(page) != linear_page_index(vma, address)); Why not VM_BUG_ON_PAGE()? -- Kirill A. Shutemov