From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C627C5DF62 for ; Wed, 6 Nov 2019 03:51:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BD91B21D81 for ; Wed, 6 Nov 2019 03:51:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="lkZ5AKd0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD91B21D81 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 690EE6B000A; Tue, 5 Nov 2019 22:51:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 642386B000C; Tue, 5 Nov 2019 22:51:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 558D66B000D; Tue, 5 Nov 2019 22:51:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 400DC6B000A for ; Tue, 5 Nov 2019 22:51:17 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id DFE748249980 for ; Wed, 6 Nov 2019 03:51:16 +0000 (UTC) X-FDA: 76124477352.04.paper44_28404100fb657 X-HE-Tag: paper44_28404100fb657 X-Filterd-Recvd-Size: 3178 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Nov 2019 03:51:16 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09B1B2087E; Wed, 6 Nov 2019 03:51:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573012275; bh=Ch2qZ4hrZWMCG0BfzRa/bcgEyOD2CW9P0h6uzzt78BU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lkZ5AKd0if3lcumlQA2ZsO0HM8ctchvN67RfVm0fze0k1k06BCszdsXCClXwDJVr6 v/zCv+t/X+B7YQirkazLBgZYED9mQ6MFrjuFcGhJ+xMOA9U5ssrUJM2iKhrsY+p6hW dVuGaKOkDg02iDxaFzOvE0IXkiSWGJzEG3VgB4qM= Date: Tue, 5 Nov 2019 19:51:14 -0800 From: Andrew Morton To: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= (VMware) Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, torvalds@linux-foundation.org, Thomas Hellstrom , Matthew Wilcox , Will Deacon , Peter Zijlstra , Rik van Riel , Minchan Kim , Michal Hocko , Huang Ying , =?ISO-8859-1?Q?J=E9r=F4me?= Glisse , "Kirill A . Shutemov" Subject: Re: [PATCH v6 4/8] mm: Add write-protect and clean utilities for address space ranges Message-Id: <20191105195114.f75be5e76763da5546121b41@linux-foundation.org> In-Reply-To: <20191014132204.7721-5-thomas_os@shipmail.org> References: <20191014132204.7721-1-thomas_os@shipmail.org> <20191014132204.7721-5-thomas_os@shipmail.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 14 Oct 2019 15:22:00 +0200 Thomas Hellstr=F6m (VMware) wrote: > Add two utilities to 1) write-protect and 2) clean all ptes pointing into > a range of an address space. > The utilities are intended to aid in tracking dirty pages (either > driver-allocated system memory or pci device memory). > The write-protect utility should be used in conjunction with > page_mkwrite() and pfn_mkwrite() to trigger write page-faults on page > accesses. Typically one would want to use this on sparse accesses into > large memory regions. The clean utility should be used to utilize > hardware dirtying functionality and avoid the overhead of page-faults, > typically on large accesses into small memory regions. Not fully comfortable reviewing this one. > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -736,4 +736,7 @@ config ARCH_HAS_PTE_SPECIAL > config ARCH_HAS_HUGEPD > bool > =20 > +config MAPPING_DIRTY_HELPERS > + bool > + But given this, it's your problem ;) So Acked-by: Andrew Morton Yes, please proceed with merging [1-4] via a drm tree.