From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66CEEC17460 for ; Tue, 5 Nov 2019 13:02:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 27CF3206B8 for ; Tue, 5 Nov 2019 13:02:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27CF3206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 97B9E6B0007; Tue, 5 Nov 2019 08:02:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9043A6B0008; Tue, 5 Nov 2019 08:02:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CB736B000A; Tue, 5 Nov 2019 08:02:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 67A376B0007 for ; Tue, 5 Nov 2019 08:02:57 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 29BE3180AD82F for ; Tue, 5 Nov 2019 13:02:57 +0000 (UTC) X-FDA: 76122238794.23.chess57_8e251dd282d25 X-HE-Tag: chess57_8e251dd282d25 X-Filterd-Recvd-Size: 3239 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 5 Nov 2019 13:02:56 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3687EADFE; Tue, 5 Nov 2019 13:02:55 +0000 (UTC) Date: Tue, 5 Nov 2019 14:02:53 +0100 From: Michal Hocko To: David Rientjes Cc: Andrew Morton , Vlastimil Babka , Linus Torvalds , Andrea Arcangeli , Mel Gorman , "Kirill A. Shutemov" , Linux Kernel Mailing List , Linux-MM Subject: Re: [patch for-5.3 0/4] revert immediate fallback to remote hugepages Message-ID: <20191105130253.GO22672@dhcp22.suse.cz> References: <20190930112817.GC15942@dhcp22.suse.cz> <20191001054343.GA15624@dhcp22.suse.cz> <20191001083743.GC15624@dhcp22.suse.cz> <20191018141550.GS5017@dhcp22.suse.cz> <53c4a6ca-a4d0-0862-8744-f999b17d82d8@suse.cz> <08a3f4dd-c3ce-0009-86c5-9ee51aba8557@suse.cz> <20191029151549.GO31513@dhcp22.suse.cz> <20191029143351.95f781f09a9fbf254163d728@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 29-10-19 16:25:17, David Rientjes wrote: > On Tue, 29 Oct 2019, Andrew Morton wrote: > > > On Tue, 29 Oct 2019 16:15:49 +0100 Michal Hocko wrote: > > > > > > > > > > 1. local node only THP allocation with no reclaim, just compaction. > > > > 2. for madvised VMA's or when synchronous compaction is enabled always - THP > > > > allocation from any node with effort determined by global defrag setting > > > > and VMA madvise > > > > 3. fallback to base pages on any node > > > > > > > > Signed-off-by: Vlastimil Babka > > > > > > I've given this a try and here are the results of my previous testcase > > > (memory full of page cache). > > > > Thanks, I'll queue this for some more testing. At some point we should > > decide on a suitable set of Fixes: tags and a backporting strategy, if any? > > > > I'd strongly suggest that Andrea test this patch out on his workload on > hosts where all nodes are low on memory because based on my understanding > of his reported issue this would result in swap storms reemerging but > worse this time because they wouldn't be constrained only locally. (This > patch causes us to no longer circumvent excessive reclaim when using > MADV_HUGEPAGE.) Could you be more specific on why this would be the case? My testing is doesn't show any such signs and I am effectivelly testing memory low situation. The amount of reclaimed memory matches the amount of requested memory. -- Michal Hocko SUSE Labs