From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A112ECA9EC7 for ; Sat, 2 Nov 2019 20:54:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4258D214AF for ; Sat, 2 Nov 2019 20:54:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qblkL1ZR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4258D214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 92BA66B0005; Sat, 2 Nov 2019 16:54:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DC426B0006; Sat, 2 Nov 2019 16:54:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F2726B0007; Sat, 2 Nov 2019 16:54:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6D6206B0005 for ; Sat, 2 Nov 2019 16:54:24 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 0FC30181AEF10 for ; Sat, 2 Nov 2019 20:54:24 +0000 (UTC) X-FDA: 76112540448.28.fang60_930ebc8b5d34 X-HE-Tag: fang60_930ebc8b5d34 X-Filterd-Recvd-Size: 2176 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Sat, 2 Nov 2019 20:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y2BVSZGLOtYso2UmMC8FMik2nU6NLubpKQk779x8UUA=; b=qblkL1ZRBi5PEhgfR+0PdSvaM OoECO8pA8R/h1IGIg62xtdJFz2ETSgNR5qdCqMYzXR+Xvxka8MmYzk0GSANGIfSYkmfu27NRkljzD 1R2mOuCwqi8h1rynk/ioaRXnDR3wJDTQaYdfmKfqrVUg8bevsJav5BuKW7k2+uyMbsDrqRvvViyg/ Qp9MV+6++6otwJBZmppdg08qUb3DW7Tk/BQILYEOwe9ZAbE74oMhBxov42PfKiK0tuPuqUHMXbLgj PXKtS5gTzH/umvyTqWrnYHOIzrCu/waCZua9bVQR5eEUclIkkvhIdEwh/tIJpNzkubXHvWJ1pfCfx g8PEF6zTQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iR0PT-0000LU-Rz; Sat, 02 Nov 2019 20:54:11 +0000 Date: Sat, 2 Nov 2019 13:54:11 -0700 From: Matthew Wilcox To: hui yang Cc: akpm@linux-foundation.org, mhocko@suse.com, dan.j.williams@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: There should have an unit (kB) Message-ID: <20191102205411.GB15832@bombadil.infradead.org> References: <1572704287-4444-1-git-send-email-yanghui.def@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572704287-4444-1-git-send-email-yanghui.def@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.105435, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 02, 2019 at 10:18:07PM +0800, hui yang wrote: > From: YangHui > > - printk(KERN_CONT " %ld", zone->lowmem_reserve[i]); > + printk(KERN_CONT " %ldkB", zone->lowmem_reserve[i]); > Make it look more perfect I don't think this is accounted in kilobytes though. Isn't it the number of pages?