From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2DFCCA9ECB for ; Thu, 31 Oct 2019 19:00:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 853B62080F for ; Thu, 31 Oct 2019 19:00:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IrUoh5Zg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 853B62080F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 25EC86B0003; Thu, 31 Oct 2019 15:00:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20F676B0005; Thu, 31 Oct 2019 15:00:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D9586B0006; Thu, 31 Oct 2019 15:00:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id E13B36B0003 for ; Thu, 31 Oct 2019 15:00:57 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 3C8A6180F76A8 for ; Thu, 31 Oct 2019 19:00:57 +0000 (UTC) X-FDA: 76104996954.15.queen84_42778b059f912 X-HE-Tag: queen84_42778b059f912 X-Filterd-Recvd-Size: 4282 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Thu, 31 Oct 2019 19:00:56 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id e66so8083143qkf.13 for ; Thu, 31 Oct 2019 12:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cq1LIrgzLt4D7jFix/b6ZOBgh+rodo6WWUZzQKJRHmc=; b=IrUoh5ZgVpBMUuwxVqPjfKMiNgJtqVbF3ZXamEE6kM2xo7Y6J0t4t3ChmgUz5N4+Hp vRSwNL0Kyeer3+YkSYZPBXldJJBnZ6XEv0hbP+znWVu+JMrCsRqPtvn6OPAHksIEP3Du PEzjOQDQdzd8vSpYjXEKUJz65bRhbDJZwf/VxbDV4af85roIwaturU+z5LfBfMSjBUMM tY/jywbAabeMrRSmbo0ptq3HOki5Kh3kfRG2Sbh5aS1PHG86/+dFh+jImmSjf4kw7Db+ R5Q8VAWM5ovSWINfYRf3rm6mpcfRwIbZwfyEzH2Db6LIMxrKwC57mRKKYP8T17PthsXR rAyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=cq1LIrgzLt4D7jFix/b6ZOBgh+rodo6WWUZzQKJRHmc=; b=YemOEuHHMPxYinf+r2/riGuP8ahxRqnyK7qVcM7JoHfA3jSYUWdQPEUXi4X81N2csi IXQ7dNhA7jlJHr6uZh4NzYRaGJLYCZ7DJzLIIPzLmGtCLvIhbZs/Lbko6L8rutnllRM7 fIlW4MrQL1XzQ4bBymktS7DKT8UjgsetlAod785oek8aiMZYZNcQjBvl9klojg3/dTGL WOcYwAM4L6kkUeiDA4rd57CSlpJ42LB/U+K1wW120t+X7BDLLWZcaW2XjeCJ26QwAfzw ANAWew7pR3oPymVQtkMau2d/ltbmoD5RceqhcogQO+R0thgGZVK/npOEKYi9mBX5hoe1 CQVw== X-Gm-Message-State: APjAAAUlKGC05zroDrl7eVLv9eQ1w7ihT8K0XNHbmaA+Wd7tH+uZamm5 2d6KneBQs6Rzsa1qj7HdVs4= X-Google-Smtp-Source: APXvYqzSjc1OryLoue6gWdyUUvcRnC5Roo0oxmkOJM6ulFr7ntxKe+KWBN7gg1UnFGoUFFGm2wXXWg== X-Received: by 2002:a37:5dc4:: with SMTP id r187mr6839078qkb.173.1572548455831; Thu, 31 Oct 2019 12:00:55 -0700 (PDT) Received: from localhost ([2620:10d:c091:500::e44c]) by smtp.gmail.com with ESMTPSA id k3sm2222682qkj.119.2019.10.31.12.00.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Oct 2019 12:00:55 -0700 (PDT) Date: Thu, 31 Oct 2019 12:00:53 -0700 From: Tejun Heo To: Shakeel Butt Cc: Eric Dumazet , Michal Hocko , "David S. Miller" , netdev@vger.kernel.org, Kernel Team , LKML , Josef Bacik , Jakub Kicinski , Johannes Weiner , Linux MM , Mel Gorman , Andrew Morton Subject: Re: [PATCH v2] net: fix sk_page_frag() recursion from memory reclaim Message-ID: <20191031190053.GN3622521@devbig004.ftw2.facebook.com> References: <20191019170141.GQ18794@devbig004.ftw2.facebook.com> <20191024205027.GF3622521@devbig004.ftw2.facebook.com> <11f688a6-0288-0ec4-f925-7b8f16ec011b@gmail.com> <20191031184346.GM3622521@devbig004.ftw2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 31, 2019 at 11:51:57AM -0700, Shakeel Butt wrote: > > Yeah, PF_MEMALLOC is likely the better condition to check here as we > > primarily want to know whether %current might be recursing and that > > should be indicated reliably with PF_MEMALLOC. Wanna prep a patch for > > it? > > Sure, I will keep your commit message and authorship (if you are ok with it). I think the patch already got merged, so it may be easier to do an incremental one. Thanks. -- tejun