From: Catalin Marinas <catalin.marinas@arm.com>
To: Steven Price <steven.price@arm.com>
Cc: "Andy Lutomirski" <luto@kernel.org>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Will Deacon" <will@kernel.org>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"Mark Rutland" <mark.rutland@arm.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"H . Peter Anvin" <hpa@zytor.com>,
"James Morse" <james.morse@arm.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: ptdump: Reduce level numbers by 1 in note_page()
Date: Thu, 31 Oct 2019 14:36:01 +0000 [thread overview]
Message-ID: <20191031143600.GD39590@arrakis.emea.arm.com> (raw)
In-Reply-To: <20191031133322.3239-1-steven.price@arm.com>
On Thu, Oct 31, 2019 at 01:33:22PM +0000, Steven Price wrote:
> Rather than having to increment the 'depth' number by 1 in
> ptdump_hole(), let's change the meaning of 'level' in note_page() since
> that makes the code simplier.
>
> Note that for x86, the level numbers were previously increased by 1 in
> commit 45dcd2091363 ("x86/mm/dump_pagetables: Fix printout of p4d level")
> and the comment "Bit 7 has a different meaning" was not updated, so this
> change also makes the code match the comment again.
>
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> arch/arm64/mm/dump.c | 6 +++---
> arch/x86/mm/dump_pagetables.c | 19 ++++++++++---------
> include/linux/ptdump.h | 1 +
> mm/ptdump.c | 16 ++++++++--------
For the arm64 part:
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2019-10-31 14:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 13:58 [PATCH v14 00/22] Generic page walk and ptdump Steven Price
2019-10-28 13:58 ` [PATCH v14 01/22] mm: Add generic p?d_leaf() macros Steven Price
2019-10-28 13:58 ` [PATCH v14 02/22] arc: mm: Add p?d_leaf() definitions Steven Price
2019-10-28 13:58 ` [PATCH v14 03/22] arm: " Steven Price
2019-10-28 13:58 ` [PATCH v14 04/22] arm64: " Steven Price
2019-10-30 15:31 ` Catalin Marinas
2019-10-28 13:58 ` [PATCH v14 05/22] mips: " Steven Price
2019-10-28 13:58 ` [PATCH v14 06/22] powerpc: " Steven Price
2019-10-28 13:58 ` [PATCH v14 07/22] riscv: " Steven Price
2019-10-28 13:58 ` [PATCH v14 08/22] s390: " Steven Price
2019-10-28 13:58 ` [PATCH v14 09/22] sparc: " Steven Price
2019-10-28 13:58 ` [PATCH v14 10/22] x86: " Steven Price
2019-10-28 13:58 ` [PATCH v14 11/22] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price
2019-10-28 13:59 ` [PATCH v14 12/22] mm: pagewalk: Allow walking without vma Steven Price
2019-10-31 15:15 ` [mm] 9343f6818b: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2019-10-31 17:22 ` Steven Price
2019-10-28 13:59 ` [PATCH v14 13/22] mm: pagewalk: Add test_p?d callbacks Steven Price
2019-10-28 13:59 ` [PATCH v14 14/22] mm: pagewalk: Add 'depth' parameter to pte_hole Steven Price
2019-10-28 13:59 ` [PATCH v14 15/22] x86: mm: Point to struct seq_file from struct pg_state Steven Price
2019-10-28 13:59 ` [PATCH v14 16/22] x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price
2019-10-28 13:59 ` [PATCH v14 17/22] x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price
2019-10-28 13:59 ` [PATCH v14 18/22] x86: mm: Convert ptdump_walk_pgd_level_core() " Steven Price
2019-10-28 13:59 ` [PATCH v14 19/22] mm: Add generic ptdump Steven Price
2019-10-30 16:48 ` Catalin Marinas
2019-10-28 13:59 ` [PATCH v14 20/22] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price
2019-10-28 13:59 ` [PATCH v14 21/22] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price
2019-10-30 16:45 ` Catalin Marinas
2019-10-31 13:32 ` Steven Price
2019-10-31 13:33 ` [PATCH] mm: ptdump: Reduce level numbers by 1 in note_page() Steven Price
2019-10-31 14:36 ` Catalin Marinas [this message]
2019-10-31 14:00 ` [PATCH v14 21/22] arm64: mm: Convert mm/dump.c to use walk_page_range() Catalin Marinas
2019-10-31 14:37 ` Catalin Marinas
2019-10-28 13:59 ` [PATCH v14 22/22] arm64: mm: Display non-present entries in ptdump Steven Price
2019-10-30 16:50 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031143600.GD39590@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jglisse@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=steven.price@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox