From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B0ACA9EC7 for ; Wed, 30 Oct 2019 18:07:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3B7BE2087E for ; Wed, 30 Oct 2019 18:07:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="mtx4zkyH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B7BE2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BA7F76B000C; Wed, 30 Oct 2019 14:07:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7ECB6B000E; Wed, 30 Oct 2019 14:07:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9D8E6B000C; Wed, 30 Oct 2019 14:07:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id 890906B000C for ; Wed, 30 Oct 2019 14:07:03 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 152F48133 for ; Wed, 30 Oct 2019 18:07:03 +0000 (UTC) X-FDA: 76101232326.22.knot01_77ac1dd9bb936 X-HE-Tag: knot01_77ac1dd9bb936 X-Filterd-Recvd-Size: 3675 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Oct 2019 18:07:02 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id r4so2116054pfl.7 for ; Wed, 30 Oct 2019 11:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IAmQqO4bjeMP8pqof8/ZbpdZpz2QFcPnCQfgAz9Gnck=; b=mtx4zkyH5XIQgQbFqvvhGqBLpk59n9jvsGvwkO1VfmeSBi1fZTkm2jd/OJyjYb00UW s0eLLTypHsbreDef1db4Dqq/lLcoO7Y1Ijt4HNbZ+EeUGjZagKB9q7s2x6NaipcKhgx9 4WhVOz5bRE5CSJI+LSDVZQr8gKMXGq4mhuGp3lThS3s7dZss+t7ixyPJXf19hzBOb0YI +ygYN0b1im2IVF2DbaB+QnHeBvBIZR00xvvEzU3MYvlmxAL9WkJsrGX3Cyc2l6CSlvE8 qU59DasqpWmvC1rofTblT3lxM1r1aBj7PmMqmcv29+qRc0d/PeGv1uLHDUQB8T6MRMGg 1M8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IAmQqO4bjeMP8pqof8/ZbpdZpz2QFcPnCQfgAz9Gnck=; b=B/jI/29TZ4Y2qfoFQAyHzMCwMl+nPO75y6ByIVx1L3T0rL0H08mh2ECblI7SRhPmIF bFGdGP25bErBIjKevCMEdA0he3LcoTj4nxG+jAScBDHxz1RpRWHul1VhCcRLUQ4cvvNb LGSt8jLE3/ZTBc2rpcgGAOYhUfWLfmWavzxmfXe3yD8xleAJtzDDw6RjuAC7OPz8myr/ wxpA2VUvQB8znfs4rjP1iEKKFZLBPp0xC+JqCYIQQhuh+Roa04pXpNo8qCQiH8nAltCX NhBwpAViO8anDZQQei+ocYjexhCKes1rUMF4PehOW9/atMB6iU1QeijTzexVv28YBMBx PM+Q== X-Gm-Message-State: APjAAAWy6bhk4skFXfk6BklGfXWP2mEn8cZG4xGXHtXgvlNJIh/jYbi1 x/lH24yrOIgHBWuVG672KpA3fw== X-Google-Smtp-Source: APXvYqyuL6I1QOntSrYa2f/+wWesgVamPWyOs/9vuQ5B6aNOTIZp/FE+XjsshHgLyFI5Yj+uUd36SQ== X-Received: by 2002:a63:352:: with SMTP id 79mr853183pgd.4.1572458820720; Wed, 30 Oct 2019 11:07:00 -0700 (PDT) Received: from localhost ([2620:10d:c090:180::78bd]) by smtp.gmail.com with ESMTPSA id c128sm573645pfc.166.2019.10.30.11.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2019 11:07:00 -0700 (PDT) Date: Wed, 30 Oct 2019 14:06:58 -0400 From: Johannes Weiner To: Michal Hocko Cc: Shakeel Butt , Greg Thelen , Roman Gushchin , Andrew Morton , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+13f93c99c06988391efe@syzkaller.appspotmail.com Subject: Re: [PATCH] mm: vmscan: memcontrol: remove mem_cgroup_select_victim_node() Message-ID: <20191030180658.GA46103@cmpxchg.org> References: <20191029234753.224143-1-shakeelb@google.com> <20191030174455.GA45135@cmpxchg.org> <20191030175302.GM31513@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030175302.GM31513@dhcp22.suse.cz> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 30, 2019 at 06:53:02PM +0100, Michal Hocko wrote: > On Wed 30-10-19 13:44:55, Johannes Weiner wrote: > > Also, I think we should use sc.gfp_mask & ~__GFP_THISNODE, so that > > allocations with a physical node preference still do node-agnostic > > reclaim for the purpose of cgroup accounting. > > Do not we exclude that by GFP_RECLAIM_MASK already? My bad, you're right. Scratch that, then. Thanks.