From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81319CA9EC5 for ; Wed, 30 Oct 2019 18:01:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 480E12087E for ; Wed, 30 Oct 2019 18:01:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 480E12087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E6B8A6B0005; Wed, 30 Oct 2019 14:01:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF4286B0007; Wed, 30 Oct 2019 14:01:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE1EA6B0008; Wed, 30 Oct 2019 14:01:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id A67606B0005 for ; Wed, 30 Oct 2019 14:01:26 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 1C8DC83E6 for ; Wed, 30 Oct 2019 18:01:26 +0000 (UTC) X-FDA: 76101218172.22.word59_46aaf856b5f13 X-HE-Tag: word59_46aaf856b5f13 X-Filterd-Recvd-Size: 4372 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Oct 2019 18:01:25 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5D6E2B257; Wed, 30 Oct 2019 18:01:24 +0000 (UTC) Date: Wed, 30 Oct 2019 19:01:16 +0100 From: Michal Hocko To: Pavel Tatashin Cc: Vincent Whitchurch , "akpm@linux-foundation.org" , "osalvador@suse.de" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mm/sparse: Consistently do not zero memmap Message-ID: <20191030180116.GN31513@dhcp22.suse.cz> References: <20191030131122.8256-1-vincent.whitchurch@axis.com> <20191030132958.GD31513@dhcp22.suse.cz> <20191030140216.i26n22asgafckfxy@axis.com> <20191030141259.GE31513@dhcp22.suse.cz> <20191030153150.GI31513@dhcp22.suse.cz> <20191030173123.GK31513@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 30-10-19 13:53:52, Pavel Tatashin wrote: > On Wed, Oct 30, 2019 at 1:31 PM Michal Hocko wrote: > > > > On Wed 30-10-19 12:53:41, Pavel Tatashin wrote: [...] > > > Yes, PMD_SIZE should be the alignment here. It just does not make > > > sense to align to size. > > > > What about this? It still aligns to the size but that should be > > correctly done to the section size level. > > > > diff --git a/mm/sparse.c b/mm/sparse.c > > index 72f010d9bff5..ab1e6175ac9a 100644 > > --- a/mm/sparse.c > > +++ b/mm/sparse.c > > @@ -456,8 +456,7 @@ struct page __init *__populate_section_memmap(unsigned long pfn, > > if (map) > > return map; > > > > - map = memblock_alloc_try_nid(size, > > - PAGE_SIZE, addr, > > + map = memblock_alloc_try_nid(size, size, addr, > > MEMBLOCK_ALLOC_ACCESSIBLE, nid); > > if (!map) > > panic("%s: Failed to allocate %lu bytes align=0x%lx nid=%d from=%pa\n", > > @@ -474,8 +473,13 @@ static void __init sparse_buffer_init(unsigned long size, int nid) > > { > > phys_addr_t addr = __pa(MAX_DMA_ADDRESS); > > WARN_ON(sparsemap_buf); /* forgot to call sparse_buffer_fini()? */ > > + /* > > + * Pre-allocated buffer is mainly used by __populate_section_memmap > > + * and we want it to be properly aligned to the section size - this is > > + * especially the case for VMEMMAP which maps memmap to PMDs > > + */ > > sparsemap_buf = > > - memblock_alloc_try_nid_raw(size, PAGE_SIZE, > > + memblock_alloc_try_nid_raw(size, section_map_size(), > > addr, > > MEMBLOCK_ALLOC_ACCESSIBLE, nid); > > sparsemap_buf_end = sparsemap_buf + size; > > This looks good, I think we should also change alignment in fallback > of vmemmap_alloc_block() to be > section_map_size(). > > +++ b/mm/sparse-vmemmap.c > @@ -65,9 +65,10 @@ void * __meminit vmemmap_alloc_block(unsigned long > size, int node) > warned = true; > } > return NULL; > - } else > - return __earlyonly_bootmem_alloc(node, size, size, > + } else { > + return __earlyonly_bootmem_alloc(node, size, section_map_size(), > __pa(MAX_DMA_ADDRESS)); > + } > } Are you sure? Doesn't this provide the proper alignement already? Most callers do PAGE_SIZE vmemmap_populate_hugepages PMD_SIZE so the resulting alignment looks good to me. -- Michal Hocko SUSE Labs