From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 008EDCA9EAE for ; Tue, 29 Oct 2019 21:36:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C080720679 for ; Tue, 29 Oct 2019 21:36:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="kM+A4zRY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C080720679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5772E6B0003; Tue, 29 Oct 2019 17:36:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 526866B0006; Tue, 29 Oct 2019 17:36:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43CA06B0007; Tue, 29 Oct 2019 17:36:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 2380A6B0003 for ; Tue, 29 Oct 2019 17:36:39 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id AF9378127 for ; Tue, 29 Oct 2019 21:36:38 +0000 (UTC) X-FDA: 76098131676.11.arch51_9147ce3cf200c X-HE-Tag: arch51_9147ce3cf200c X-Filterd-Recvd-Size: 1894 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Tue, 29 Oct 2019 21:36:38 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 01DB120659; Tue, 29 Oct 2019 21:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572384997; bh=MNqf/t/GIceJ+JJkh1MveTBw/I/7e0hETNFzW+kg1ZQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kM+A4zRY55SfHdAj4eMIsTKDVnKZ8W8VPhX2XW1qf4V71G4vLHnQ3C8q3+aTk2bNR Af99rwgKErRPn0AlqtW5rOi+8HH1kRicW7rb5ewiNP736xUwAICn71KND/E5qrRd16 AQLUhWeh1qsHKzBG8NELeWDnFGTukI2wLHpYs3YU= Date: Tue, 29 Oct 2019 14:36:36 -0700 From: Andrew Morton To: zhong jiang Cc: , , Subject: Re: [PATCH] mm/cma_debug: Use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops Message-Id: <20191029143636.6ef9390992ffd1879ac9ad3b@linux-foundation.org> In-Reply-To: <1572348687-9951-1-git-send-email-zhongjiang@huawei.com> References: <1572348687-9951-1-git-send-email-zhongjiang@huawei.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 29 Oct 2019 19:31:27 +0800 zhong jiang wrote: > It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs > file operation rather than DEFINE_SIMPLE_ATTRIBUTE. hm, they do appear to be identical. Perhaps DEFINE_DEBUGFS_ATTRIBUTE shouldn't exist, or should be #defined onto DEFINE_SIMPLE_ATTRIBUTE?