From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2907CA9EC0 for ; Mon, 28 Oct 2019 12:57:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6BBBC20873 for ; Mon, 28 Oct 2019 12:57:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="srML+4c4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BBBC20873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1BF9D6B0007; Mon, 28 Oct 2019 08:57:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16FD66B0008; Mon, 28 Oct 2019 08:57:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 037EE6B000A; Mon, 28 Oct 2019 08:57:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id D0D816B0007 for ; Mon, 28 Oct 2019 08:57:03 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 62940180ACEE4 for ; Mon, 28 Oct 2019 12:57:03 +0000 (UTC) X-FDA: 76093193526.03.gun32_3d8686ec43c35 X-HE-Tag: gun32_3d8686ec43c35 X-Filterd-Recvd-Size: 4448 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Mon, 28 Oct 2019 12:57:02 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id m9so1547010ljh.8 for ; Mon, 28 Oct 2019 05:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0z8rcnJQ2Ztw3XS+4jmpXqQHR2gbd+xnEDMVQdJ2PKg=; b=srML+4c4W5XX21msxWpc4UTlLGRvocfhX+m8lvWZmTqWJ5JCiI2mfWZTnHxVqaYfjb RZj0UT8eW/naYqmghTosmknDZj7Xpio4LxUzGrGSO3//giGKDQmYVrnZ/paCFuFAQcsB V7znTFFwZzkN0gTbaEAl9TrDNfH1cG7W0wF73Ynd7rAmULk2w/g74sEdzHqe4AhDJ+3H vPLMBrEepytPqjx0ZwiWK8rMJ4d7YqC1t7Ci1xJs9k1l4TphNVHkdFQ5/Xx3FdjDjY1D qJp1PdMkWXv1nkI0LJwRV0l4SfjCylX+qDHekhf7ufySNb4+QR/AwOoYHWdrxpSqs3Sq uUiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0z8rcnJQ2Ztw3XS+4jmpXqQHR2gbd+xnEDMVQdJ2PKg=; b=fd5sKZRp5QyAR+U5TMO30bI9Fnfru1Iol3F48gsbT0p8LLU1Mk36/4SgVCBDEq+Qry r4Mt2/r2bY0KVOgoLi76S1i0gJGdLanhaqDiwQ/kdL7j9azyPTRQpmNlDbKrHhIEjmJF 6iy4wvDk7Gk7UOlMEOErwrvbrheK3nJz7nohyoMAuijYLijfsjLK/qtZLyHVCtHqltSE 4d8eM/69qpCHUxtCs5+tmJm/wfXy+3gKrwhdt6WWPQD2ZwoiYLyzW58gAdAC30kFVCxa zlfeuurjKbVkNK5MXlueukZ23HPYPxGdojV8oriRaut9+ab7efN3Vj9Hqp9N7Zil/ESO OGSg== X-Gm-Message-State: APjAAAVNuBG0rJ2sauJ9dF/q5+NnlrxqDi2zD+eeLUfQM8fqqx6Ue5Yf MekeH+z9dJZDLyz5Ndj+mLNEnA== X-Google-Smtp-Source: APXvYqxnZmY+iQCpMLmbeFZh5dem+tdNcGHC4iY1KE4BMNoGuCBgfBV/T08SYVaI0ko2KXi+altLhA== X-Received: by 2002:a2e:9759:: with SMTP id f25mr175210ljj.173.1572267421409; Mon, 28 Oct 2019 05:57:01 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id a11sm5241245ljp.97.2019.10.28.05.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 05:57:00 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id C0662100242; Mon, 28 Oct 2019 15:57:02 +0300 (+03) Date: Mon, 28 Oct 2019 15:57:02 +0300 From: "Kirill A. Shutemov" To: Linus Torvalds Cc: Konstantin Khlebnikov , Linux-MM , Andrew Morton , Linux Kernel Mailing List , linux-fsdevel , Alexander Viro , Johannes Weiner , Steven Whitehouse Subject: Re: [PATCH] mm/filemap: do not allocate cache pages beyond end of file at read Message-ID: <20191028125702.xdfbs7rqhm3wer5t@box> References: <157225677483.3442.4227193290486305330.stgit@buzz> <20191028124222.ld6u3dhhujfqcn7w@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 28, 2019 at 01:47:16PM +0100, Linus Torvalds wrote: > On Mon, Oct 28, 2019 at 1:42 PM Kirill A. Shutemov wrote: > > > > I've tried something of this sort back in 2013: > > > > http://lore.kernel.org/r/1377099441-2224-1-git-send-email-kirill.shutemov@linux.intel.com > > > > and I've got push back. > > > > Apparently, some filesystems may not have valid i_size before >readpage(). > > Not sure if it's still the case... > > Well, I agree that there might be some network filesystem that might > have inode sizes that are stale, but if that's the case then I don't > think your previous patch works either. > > It too will avoid the readpage() if the read position is beyond i_size. > > No? Yes. That's the reason the patch was rejected back then. My point is that we need to make sure that this patch not break anything. -- Kirill A. Shutemov