From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDF1DCA9EA0 for ; Fri, 25 Oct 2019 15:36:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7AA8321D7B for ; Fri, 25 Oct 2019 15:36:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="L75ud86K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AA8321D7B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 253F16B0005; Fri, 25 Oct 2019 11:36:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 204D46B0006; Fri, 25 Oct 2019 11:36:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F2D16B0007; Fri, 25 Oct 2019 11:36:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id DDB6B6B0005 for ; Fri, 25 Oct 2019 11:36:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 943098249980 for ; Fri, 25 Oct 2019 15:36:22 +0000 (UTC) X-FDA: 76082708604.02.clam46_71caa279a9852 X-HE-Tag: clam46_71caa279a9852 X-Filterd-Recvd-Size: 4145 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 25 Oct 2019 15:36:21 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id 139so3025404ljf.1 for ; Fri, 25 Oct 2019 08:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VlfRIm/IUQoWr2pXkJdNPTQB7pso0Fzi7iIhyuUYMCY=; b=L75ud86KWGPHxPbqsE9fYUV589praE+7kUBzz8/hFeYfnkE8fGeAHqRdb8aN8jIm4w zwageU2OR8t7hf7+ngdaTZtqyGunHZMDWOLObCvkvSlTGjc55LsULJyClg+ttQAlqI32 pLuSMdHO/IwduciZYA4QMk0OOMeuslnCC+VtWuqmJ6ntQHMdHyB4viEdkQ7PhNtp2e3W fclXfviKT7AjiDJ7QddXszNO6UWj2BCAzJQFg+vFW6ZKUz5o/PrYPFOCggvaLqeniVjp m7Pf3AW42s/vOFU0xM8h8oA+pYErBikv9SL3yl4hol4RbFGyh1714xhDJ/iWhHxm2uj3 cn1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VlfRIm/IUQoWr2pXkJdNPTQB7pso0Fzi7iIhyuUYMCY=; b=qWd70FnJF0mcs4Qacl5hPcxvz3zZ6cAayBwUXVEbFvp+bK3/TedlaZg9+NafbZtSnH Ojtv+P5gSH60QE5ycC6ryUs1acIKszyjjgy5Y4AE8YifEM4ckStPcfvy7Oq+9pT9E/IY Mc3LbRZhAyE4Vx+x4cyuzVb5vnG803QtegfLkDbUrrj9ELZ9M4w762JnvcN4/FqPUIXC CNijs2eM4UW7/eHa9SPJqG8/+66qtrhPrlFraUiP5wY5tMM631GMN6FZ5NtXX6R9xYkz OoG8uc7i6B291HFIECA0V71IxAnI5EFIrCwq5PgQvenfBAgsXSjdQsoq2pKDe37r9m8v ZXog== X-Gm-Message-State: APjAAAVhAJvLlcMYFzM3T2whoM3c77AqNGvnWXc/FnrEctgUyVLqIOhl lnz0C4q+BTIt6gwhnoF5oB9msg== X-Google-Smtp-Source: APXvYqxRA08GLyrFbHx8Xl51vJWvwsWvNv8hMTj3SCmTGJGUX46vOnxceXakMrAQ4rUIrnz2oASJvw== X-Received: by 2002:a2e:4e12:: with SMTP id c18mr3037222ljb.51.1572017780299; Fri, 25 Oct 2019 08:36:20 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id b6sm1066987lfi.72.2019.10.25.08.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2019 08:36:19 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 04DB810267F; Fri, 25 Oct 2019 18:36:19 +0300 (+03) Date: Fri, 25 Oct 2019 18:36:18 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: hughd@google.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: thp: clear PageDoubleMap flag when the last PMD map gone Message-ID: <20191025153618.ajcecye3bjm5abax@box> References: <1571938066-29031-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1571938066-29031-1-git-send-email-yang.shi@linux.alibaba.com> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 25, 2019 at 01:27:46AM +0800, Yang Shi wrote: > File THP sets PageDoubleMap flag when the first it gets PTE mapped, but > the flag is never cleared until the THP is freed. This result in > unbalanced state although it is not a big deal. > > Clear the flag when the last compound_mapcount is gone. It should be > cleared when all the PTE maps are gone (become PMD mapped only) as well, > but this needs check all subpage's _mapcount every time any subpage's > rmap is removed, the overhead may be not worth. The anonymous THP also > just clears PageDoubleMap flag when the last PMD map is gone. NAK, sorry. The key difference with anon THP that file THP can be mapped again with PMD after all PMD (or all) mappings are gone. Your patch breaks the case when you map the page with PMD again while the page is still mapped with PTEs. Who would set PageDoubleMap() in this case? -- Kirill A. Shutemov