From: kbuild test robot <lkp@intel.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: kbuild-all@lists.01.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Greentime Hu <green.hu@gmail.com>,
Greg Ungerer <gerg@linux-m68k.org>, Helge Deller <deller@gmx.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Jeff Dike <jdike@addtoit.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mark Salter <msalter@redhat.com>,
Matt Turner <mattst88@gmail.com>, Michal Simek <monstr@monstr.eu>,
Richard Weinberger <richard@nod.at>,
Russell King <linux@armlinux.org.uk>,
Sam Creasey <sammy@sammy.net>, Vincent Chen <deanbo422@gmail.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Mike Rapoport <rppt@kernel.org>,
linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-parisc@vger.kernel.org,
linux-um@lists.infradead.org, sparclinux@vger.kernel.org,
Mike Rapoport <rppt@linux.ibm.com>
Subject: Re: [PATCH 06/12] microblaze: use pgtable-nopmd instead of 4level-fixup
Date: Fri, 25 Oct 2019 10:17:29 +0800 [thread overview]
Message-ID: <201910251024.I6neM4qC%lkp@intel.com> (raw)
In-Reply-To: <1571822941-29776-7-git-send-email-rppt@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 6108 bytes --]
Hi Mike,
I love your patch! Yet something to improve:
[auto build test ERROR on mmotm/master]
url: https://github.com/0day-ci/linux/commits/Mike-Rapoport/mm-remove-__ARCH_HAS_4LEVEL_HACK/20191025-063009
base: git://git.cmpxchg.org/linux-mmotm.git master
config: microblaze-mmu_defconfig (attached as .config)
compiler: microblaze-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from include/linux/shm.h:6:0,
from include/linux/sched.h:16,
from arch/microblaze/mm/consistent.c:15:
arch/microblaze/mm/consistent.c: In function 'consistent_virt_to_pte':
>> arch/microblaze/include/asm/pgtable.h:458:34: error: passing argument 1 of 'pmd_offset' from incompatible pointer type [-Werror=incompatible-pointer-types]
#define pgd_offset(mm, address) ((mm)->pgd + pgd_index(address))
^
arch/microblaze/include/asm/page.h:105:30: note: in definition of macro 'pgd_val'
# define pgd_val(x) ((x).pgd)
^
>> include/asm-generic/pgtable-nopud.h:50:24: note: in expansion of macro 'p4d_val'
#define pud_val(x) (p4d_val((x).p4d))
^~~~~~~
>> include/asm-generic/pgtable-nopmd.h:49:24: note: in expansion of macro 'pud_val'
#define pmd_val(x) (pud_val((x).pud))
^~~~~~~
>> arch/microblaze/include/asm/pgtable.h:448:48: note: in expansion of macro 'pmd_val'
#define pmd_page_kernel(pmd) ((unsigned long) (pmd_val(pmd) & PAGE_MASK))
^~~~~~~
>> arch/microblaze/include/asm/pgtable.h:464:13: note: in expansion of macro 'pmd_page_kernel'
((pte_t *) pmd_page_kernel(*(dir)) + pte_index(addr))
^~~~~~~~~~~~~~~
>> arch/microblaze/mm/consistent.c:162:9: note: in expansion of macro 'pte_offset_kernel'
return pte_offset_kernel(pmd_offset(pgd_offset_k(addr), addr), addr);
^~~~~~~~~~~~~~~~~
>> arch/microblaze/include/asm/pgtable.h:454:31: note: in expansion of macro 'pgd_offset'
#define pgd_offset_k(address) pgd_offset(&init_mm, address)
^~~~~~~~~~
>> arch/microblaze/mm/consistent.c:162:38: note: in expansion of macro 'pgd_offset_k'
return pte_offset_kernel(pmd_offset(pgd_offset_k(addr), addr), addr);
^~~~~~~~~~~~
In file included from arch/microblaze/include/asm/pgtable.h:62:0,
from include/linux/mm.h:99,
from arch/microblaze/include/asm/uaccess.h:15,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/ptrace.h:7,
from arch/microblaze/mm/consistent.c:20:
include/asm-generic/pgtable-nopmd.h:44:23: note: expected 'pud_t * {aka struct <anonymous> *}' but argument is of type 'pgd_t * {aka struct <anonymous> *}'
static inline pmd_t * pmd_offset(pud_t * pud, unsigned long address)
^~~~~~~~~~
cc1: some warnings being treated as errors
vim +/pmd_offset +458 arch/microblaze/include/asm/pgtable.h
15902bf63c8332 Michal Simek 2009-05-26 444
15902bf63c8332 Michal Simek 2009-05-26 445 /* Convert pmd entry to page */
15902bf63c8332 Michal Simek 2009-05-26 446 /* our pmd entry is an effective address of pte table*/
15902bf63c8332 Michal Simek 2009-05-26 447 /* returns effective address of the pmd entry*/
15902bf63c8332 Michal Simek 2009-05-26 @448 #define pmd_page_kernel(pmd) ((unsigned long) (pmd_val(pmd) & PAGE_MASK))
15902bf63c8332 Michal Simek 2009-05-26 449
15902bf63c8332 Michal Simek 2009-05-26 450 /* returns struct *page of the pmd entry*/
15902bf63c8332 Michal Simek 2009-05-26 451 #define pmd_page(pmd) (pfn_to_page(__pa(pmd_val(pmd)) >> PAGE_SHIFT))
15902bf63c8332 Michal Simek 2009-05-26 452
15902bf63c8332 Michal Simek 2009-05-26 453 /* to find an entry in a kernel page-table-directory */
15902bf63c8332 Michal Simek 2009-05-26 @454 #define pgd_offset_k(address) pgd_offset(&init_mm, address)
15902bf63c8332 Michal Simek 2009-05-26 455
15902bf63c8332 Michal Simek 2009-05-26 456 /* to find an entry in a page-table-directory */
15902bf63c8332 Michal Simek 2009-05-26 457 #define pgd_index(address) ((address) >> PGDIR_SHIFT)
15902bf63c8332 Michal Simek 2009-05-26 @458 #define pgd_offset(mm, address) ((mm)->pgd + pgd_index(address))
15902bf63c8332 Michal Simek 2009-05-26 459
15902bf63c8332 Michal Simek 2009-05-26 460 /* Find an entry in the third-level page table.. */
15902bf63c8332 Michal Simek 2009-05-26 461 #define pte_index(address) \
15902bf63c8332 Michal Simek 2009-05-26 462 (((address) >> PAGE_SHIFT) & (PTRS_PER_PTE - 1))
15902bf63c8332 Michal Simek 2009-05-26 463 #define pte_offset_kernel(dir, addr) \
15902bf63c8332 Michal Simek 2009-05-26 @464 ((pte_t *) pmd_page_kernel(*(dir)) + pte_index(addr))
15902bf63c8332 Michal Simek 2009-05-26 465 #define pte_offset_map(dir, addr) \
ece0e2b6406a99 Peter Zijlstra 2010-10-26 466 ((pte_t *) kmap_atomic(pmd_page(*(dir))) + pte_index(addr))
15902bf63c8332 Michal Simek 2009-05-26 467
:::::: The code at line 458 was first introduced by commit
:::::: 15902bf63c8332946e5a1f48a72e3ae22874b11b microblaze_mmu_v2: Page table - ioremap - pgtable.c/h, section update
:::::: TO: Michal Simek <monstr@monstr.eu>
:::::: CC: Michal Simek <monstr@monstr.eu>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 14079 bytes --]
next prev parent reply other threads:[~2019-10-25 2:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 9:28 [PATCH 00/12] mm: remove __ARCH_HAS_4LEVEL_HACK Mike Rapoport
2019-10-23 9:28 ` [PATCH 01/12] alpha: use pgtable-nop4d instead of 4level-fixup Mike Rapoport
2019-10-23 9:28 ` [PATCH 02/12] arm: nommu: use pgtable-nopud " Mike Rapoport
2019-10-23 9:40 ` Russell King - ARM Linux admin
2019-10-23 9:28 ` [PATCH 03/12] c6x: " Mike Rapoport
2019-10-23 9:28 ` [PATCH 04/12] m68k: nommu: " Mike Rapoport
2019-10-24 4:09 ` Greg Ungerer
2019-10-24 5:35 ` Mike Rapoport
2019-10-24 6:23 ` Greg Ungerer
2019-10-23 9:28 ` [PATCH 05/12] m68k: mm: use pgtable-nopXd " Mike Rapoport
2019-10-24 4:12 ` Greg Ungerer
2019-10-25 5:52 ` kbuild test robot
2019-10-23 9:28 ` [PATCH 06/12] microblaze: use pgtable-nopmd " Mike Rapoport
2019-10-25 2:17 ` kbuild test robot [this message]
2019-10-25 8:24 ` Michal Simek
2019-10-25 20:33 ` Mike Rapoport
2019-10-23 9:28 ` [PATCH 07/12] nds32: " Mike Rapoport
2019-10-23 9:28 ` [PATCH 08/12] parisc: use pgtable-nopXd " Mike Rapoport
2019-10-23 10:20 ` Rolf Eike Beer
2019-10-24 8:51 ` Mike Rapoport
2019-10-24 9:35 ` Peter Rosin
2019-10-24 9:50 ` Mike Rapoport
2019-10-23 9:28 ` [PATCH 09/12] sparc32: use pgtable-nopud " Mike Rapoport
2019-10-23 19:59 ` [PATCH v2 " Mike Rapoport
2019-10-23 21:21 ` David Miller
2019-10-23 9:28 ` [PATCH 10/12] um: remove unused pxx_offset_proc() and addr_pte() functions Mike Rapoport
2019-10-23 9:29 ` [PATCH 11/12] um: add support for folded p4d page tables Mike Rapoport
2019-10-23 9:29 ` [PATCH 12/12] mm: remove __ARCH_HAS_4LEVEL_HACK and include/asm-generic/4level-fixup.h Mike Rapoport
2019-10-23 10:25 ` [PATCH 00/12] mm: remove __ARCH_HAS_4LEVEL_HACK Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910251024.I6neM4qC%lkp@intel.com \
--to=lkp@intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=deanbo422@gmail.com \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=green.hu@gmail.com \
--cc=jdike@addtoit.com \
--cc=kbuild-all@lists.01.org \
--cc=kirill@shutemov.name \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mattst88@gmail.com \
--cc=monstr@monstr.eu \
--cc=msalter@redhat.com \
--cc=richard@nod.at \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=sammy@sammy.net \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox