From: kbuild test robot <lkp@intel.com>
To: "Thomas Hellström (VMware)" <thomas_os@shipmail.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Thomas Hellstrom <thellstrom@vmware.com>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] mm: Fix a huge pud insertion race during faulting
Date: Thu, 24 Oct 2019 19:45:01 +0800 [thread overview]
Message-ID: <201910241921.oi4h7o4m%lkp@intel.com> (raw)
In-Reply-To: <20191022123003.37089-1-thomas_os@shipmail.org>
[-- Attachment #1: Type: text/plain, Size: 3061 bytes --]
Hi "Thomas,
I love your patch! Yet something to improve:
[auto build test ERROR on mmotm/master]
url: https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m-VMware/mm-Fix-a-huge-pud-insertion-race-during-faulting/20191024-175905
base: git://git.cmpxchg.org/linux-mmotm.git master
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=um SUBARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/um/include/asm/pgtable.h:363:0,
from include/linux/mm.h:99,
from include/linux/memcontrol.h:20,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from init/do_mounts.c:7:
include/asm-generic/pgtable.h: In function 'pud_none_or_trans_huge_or_dev_or_clear_bad':
>> include/asm-generic/pgtable.h:920:52: error: implicit declaration of function 'pud_devmap'; did you mean 'put_device'? [-Werror=implicit-function-declaration]
if (pud_none(pudval) || pud_trans_huge(pudval) || pud_devmap(pudval))
^~~~~~~~~~
put_device
In file included from include/linux/memcontrol.h:20:0,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from init/do_mounts.c:7:
include/linux/mm.h: At top level:
include/linux/mm.h:572:19: error: static declaration of 'pud_devmap' follows non-static declaration
static inline int pud_devmap(pud_t pud)
^~~~~~~~~~
In file included from arch/um/include/asm/pgtable.h:363:0,
from include/linux/mm.h:99,
from include/linux/memcontrol.h:20,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from init/do_mounts.c:7:
include/asm-generic/pgtable.h:920:52: note: previous implicit declaration of 'pud_devmap' was here
if (pud_none(pudval) || pud_trans_huge(pudval) || pud_devmap(pudval))
^~~~~~~~~~
cc1: some warnings being treated as errors
vim +920 include/asm-generic/pgtable.h
914
915 /* See pmd_none_or_trans_huge_or_clear_bad for discussion. */
916 static inline int pud_none_or_trans_huge_or_dev_or_clear_bad(pud_t *pud)
917 {
918 pud_t pudval = READ_ONCE(*pud);
919
> 920 if (pud_none(pudval) || pud_trans_huge(pudval) || pud_devmap(pudval))
921 return 1;
922 if (unlikely(pud_bad(pudval))) {
923 pud_clear_bad(pud);
924 return 1;
925 }
926 return 0;
927 }
928
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 8335 bytes --]
prev parent reply other threads:[~2019-10-24 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 12:30 Thomas Hellström (VMware)
2019-10-24 10:36 ` kbuild test robot
2019-10-24 11:45 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910241921.oi4h7o4m%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=thellstrom@vmware.com \
--cc=thomas_os@shipmail.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox