From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D7B2CA9EB6 for ; Wed, 23 Oct 2019 18:02:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D12B22086D for ; Wed, 23 Oct 2019 18:02:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D12B22086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7C8736B0008; Wed, 23 Oct 2019 14:02:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 751B06B000A; Wed, 23 Oct 2019 14:02:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 667166B000C; Wed, 23 Oct 2019 14:02:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 3E1F26B0008 for ; Wed, 23 Oct 2019 14:02:20 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id BFFDF180013F4 for ; Wed, 23 Oct 2019 18:02:19 +0000 (UTC) X-FDA: 76075818798.07.robin58_6b971f09af62f X-HE-Tag: robin58_6b971f09af62f X-Filterd-Recvd-Size: 2021 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Oct 2019 18:02:19 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5B587AE6F; Wed, 23 Oct 2019 18:02:18 +0000 (UTC) Date: Wed, 23 Oct 2019 20:02:17 +0200 From: Michal Hocko To: Waiman Long Cc: Andrew Morton , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Johannes Weiner , Roman Gushchin , Vlastimil Babka , Konstantin Khlebnikov , Jann Horn , Song Liu , Greg Kroah-Hartman , Rafael Aquini Subject: Re: [PATCH 2/2] mm, vmstat: List total free blocks for each order in /proc/pagetypeinfo Message-ID: <20191023180217.GO17610@dhcp22.suse.cz> References: <20191023102737.32274-3-mhocko@kernel.org> <20191023173423.12532-2-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023173423.12532-2-longman@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 23-10-19 13:34:23, Waiman Long wrote: [...] > @@ -1419,6 +1419,17 @@ static void pagetypeinfo_showfree_print(struct seq_file *m, > } > seq_putc(m, '\n'); > } > + > + /* > + * List total free blocks per order > + */ > + seq_printf(m, "Node %4d, zone %8s, total ", > + pgdat->node_id, zone->name); > + for (order = 0; order < MAX_ORDER; ++order) { > + area = &(zone->free_area[order]); > + seq_printf(m, "%6lu ", area->nr_free); > + } > + seq_putc(m, '\n'); This is essentially duplicating /proc/buddyinfo. Do we really need that? -- Michal Hocko SUSE Labs