From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB2ECA9EAD for ; Sun, 20 Oct 2019 09:32:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 37876218BA for ; Sun, 20 Oct 2019 09:32:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37876218BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9633F8E0005; Sun, 20 Oct 2019 05:32:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 914568E0003; Sun, 20 Oct 2019 05:32:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 829DD8E0005; Sun, 20 Oct 2019 05:32:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 622F08E0003 for ; Sun, 20 Oct 2019 05:32:42 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id DE890180AD81F for ; Sun, 20 Oct 2019 09:32:41 +0000 (UTC) X-FDA: 76063648122.26.tree09_8be799ab70924 X-HE-Tag: tree09_8be799ab70924 X-Filterd-Recvd-Size: 3438 Received: from outbound-smtp12.blacknight.com (outbound-smtp12.blacknight.com [46.22.139.17]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Sun, 20 Oct 2019 09:32:41 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp12.blacknight.com (Postfix) with ESMTPS id D63C31C3326 for ; Sun, 20 Oct 2019 10:32:37 +0100 (IST) Received: (qmail 31103 invoked from network); 20 Oct 2019 09:32:37 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.19.210]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 20 Oct 2019 09:32:37 -0000 Date: Sun, 20 Oct 2019 10:32:35 +0100 From: Mel Gorman To: Andrew Morton Cc: Michal Hocko , Vlastimil Babka , Thomas Gleixner , Matt Fleming , Borislav Petkov , Linux-MM , Linux Kernel Mailing List Subject: Re: [PATCH 2/3] mm, meminit: Recalculate pcpu batch and high limits after init completes Message-ID: <20191020093235.GL3321@techsingularity.net> References: <20191018105606.3249-1-mgorman@techsingularity.net> <20191018105606.3249-3-mgorman@techsingularity.net> <20191018130127.GP5017@dhcp22.suse.cz> <20191018140959.GK3321@techsingularity.net> <20191018184024.2bb1a69997a9365c5d4ccf1c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20191018184024.2bb1a69997a9365c5d4ccf1c@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 18, 2019 at 06:40:24PM -0700, Andrew Morton wrote: > On Fri, 18 Oct 2019 15:09:59 +0100 Mel Gorman wrote: > > > > > Cc: stable@vger.kernel.org # v4.15+ > > > > > > Hmm, are you sure about 4.15? Doesn't this go all the way down to > > > deferred initialization? I do not see any recent changes on when > > > setup_per_cpu_pageset is called. > > > > > > > No, I'm not 100% sure. It looks like this was always an issue from the > > code but did not happen on at least one 4.12-based distribution kernel for > > reasons that are non-obvious. Either way, the tag should have been "v4.1+" > > I could mark > > mm-pcp-share-common-code-between-memory-hotplug-and-percpu-sysctl-handler.patch > mm-meminit-recalculate-pcpu-batch-and-high-limits-after-init-completes.patch > > as Cc: [4.1+] > That would be fine. > But for backporting purposes it's a bit cumbersome that [2/3] is the > important patch. I think I'll switch the ordering so that > mm-meminit-recalculate-pcpu-batch-and-high-limits-after-init-completes.patch > is the first patch and the other two can be queued for 5.5-rc1, OK? > It might be easier to simply collapse patch 1 and 2 together. They were only split to make the review easier and to avoid two relatively big changes in one patch. > Also, is a Reported-by:Matt appropriate here? > I don't object but I'm not actually sure who reported this first. I think it was Thomas who talked to Boris about an EPYC performance issue, who talked to Matt thinking it might be a scheduler issue who identified it was my problem :P -- Mel Gorman SUSE Labs