From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E858CA9EAC for ; Sat, 19 Oct 2019 15:51:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D528621925 for ; Sat, 19 Oct 2019 15:51:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iSujy8Xy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D528621925 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 74E578E0006; Sat, 19 Oct 2019 11:51:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FEE18E0003; Sat, 19 Oct 2019 11:51:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EE538E0006; Sat, 19 Oct 2019 11:51:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id 4166B8E0003 for ; Sat, 19 Oct 2019 11:51:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id E35678249980 for ; Sat, 19 Oct 2019 15:51:47 +0000 (UTC) X-FDA: 76060974654.14.rail68_2cbfd9fdd8506 X-HE-Tag: rail68_2cbfd9fdd8506 X-Filterd-Recvd-Size: 4669 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Sat, 19 Oct 2019 15:51:47 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id m13so9092924ljj.11 for ; Sat, 19 Oct 2019 08:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=T/AGAu62ovkqmmOaipnU4qwxs2oksLKTDo7XFRANQ34=; b=iSujy8XyB/9+LufsCiBp9n5mGxdaqfiezYUI0un1OjDum+O2GENbFfibBnvxTGOnHy Ik1w2XzMm5jeNF5fp5FjC9rRsqtq5BQi7FA5u9tbEOu/SYIzRlZ8JWtBPoy4nM3pap7V 6DwJrb2xPySVxBaPx71Ywu7McX5gEnLlWjZLVe/YlvJEQa7zZL+Bwc30drr6Vra8jHsK GZ2dP0FWv11nLhl427O2i9ZdtR4H/Zj25KmYaRlYgIp4WWlsQV7dOb3VVZmmkAmNiQiL P/aXxUSPVNyY7Z/x1RBUpZ1A1WgZ5aUMikghQV85KyNzB2SjIBqyGEAOJ1JyTY5wl5q+ bU9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=T/AGAu62ovkqmmOaipnU4qwxs2oksLKTDo7XFRANQ34=; b=WsWRJdBJi+9KZOMTA+DioZgjLqQE0kTgEzDolf8tjEOO//ASmNFw+VXxSPuXpjNSvT RBRTLoNxa9UybyvAEpyM6yonlk4ecrX6arhalfQpjECQEGhc9sW+X1qMv0fJNYb00ZFT Y2x5W4Nyv7+SDzrDC16kxQZdfuYnwMBHLVjSulo5qjub0oEajp4PQ6+X9VAnUauTmSbE s2JXi+kmQswM6xIz496SbIYjHLlAs4ouZsx9HvEMZ8z68YrarpxmCtYYGpXGVyYZLjAm VvdhQZLrInQEmUiWpMJ3YcZvjeWQo+JSiEBtIo+hWX5NP30lrG5MCLX/L0QYLcxDlAo2 01Wg== X-Gm-Message-State: APjAAAVYOwI7pNly/7fUBpRsZMZf3dtaVndqpPxRac2IvOOlVFc6hyKM ye++JhZwsaoo5QsTzvrIepg= X-Google-Smtp-Source: APXvYqzrzVT4jLUO81aUaygCshaJH6cPq2ieZ6ehY7potGY6gHloPziZZZxHJsVFWT416QG6SSNbzg== X-Received: by 2002:a2e:9b02:: with SMTP id u2mr9865388lji.50.1571500305667; Sat, 19 Oct 2019 08:51:45 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id h3sm5903773ljf.12.2019.10.19.08.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Oct 2019 08:51:44 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Sat, 19 Oct 2019 17:51:35 +0200 To: Andrew Morton Cc: Uladzislau Rezki , Michal Hocko , Daniel Wagner , Sebastian Andrzej Siewior , Thomas Gleixner , linux-mm@kvack.org, LKML , Peter Zijlstra , Hillf Danton , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH v3 2/3] mm/vmalloc: respect passed gfp_mask when do preloading Message-ID: <20191019155135.GA13781@pc636> References: <20191016095438.12391-1-urezki@gmail.com> <20191016095438.12391-2-urezki@gmail.com> <20191016110604.GT317@dhcp22.suse.cz> <20191018094049.GB8744@pc636> <20191018185856.1a77fc3a14a58ec18ca76a59@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018185856.1a77fc3a14a58ec18ca76a59@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > > > > > This is explaining what but it doesn't say why. I would go with > > > " > > > Allocation functions should comply with the given gfp_mask as much as > > > possible. The preallocation code in alloc_vmap_area doesn't follow that > > > pattern and it is using a hardcoded GFP_KERNEL. Although this doesn't > > > really make much difference because vmalloc is not GFP_NOWAIT compliant > > > in general (e.g. page table allocations are GFP_KERNEL) there is no > > > reason to spread that bad habit and it is good to fix the antipattern. > > > " > > I can go with that, agree. I am not sure if i need to update the patch > > and send v4. Or maybe Andrew can directly update it in his tree. > > > > Andrew, should i send or can update? > > I updated the changelog with Michal's words prior to committing. You > were cc'ed :) > Ah, i saw the email stating that the patch has been added to the "mm" tree, but i did not check the commit message. Now i see everything is sorted out :) Thank you! -- Vlad Rezki