* [patch 10/26] mm/gup_benchmark: add a missing "w" to getopt string
@ 2019-10-19 3:19 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2019-10-19 3:19 UTC (permalink / raw)
To: akpm, aneesh.kumar, hch, hch, ira.weiny, jhubbard, keith.busch,
kirill.shutemov, linux-mm, lkp, mm-commits, shuah, torvalds
From: John Hubbard <jhubbard@nvidia.com>
Subject: mm/gup_benchmark: add a missing "w" to getopt string
Even though gup_benchmark.c has code to handle the -w command-line option,
the "w" is not part of the getopt string. It looks as if it has been
missing the whole time.
On my machine, this leads naturally to the following predictable result:
$ sudo ./gup_benchmark -w
./gup_benchmark: invalid option -- 'w'
...which is fixed, with this commit.
Link: http://lkml.kernel.org/r/20191014184639.1512873-2-jhubbard@nvidia.com
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: kbuild test robot <lkp@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
tools/testing/selftests/vm/gup_benchmark.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/tools/testing/selftests/vm/gup_benchmark.c~mm-gup_benchmark-add-a-missing-w-to-getopt-string
+++ a/tools/testing/selftests/vm/gup_benchmark.c
@@ -37,7 +37,7 @@ int main(int argc, char **argv)
char *file = "/dev/zero";
char *p;
- while ((opt = getopt(argc, argv, "m:r:n:f:tTLUSH")) != -1) {
+ while ((opt = getopt(argc, argv, "m:r:n:f:tTLUwSH")) != -1) {
switch (opt) {
case 'm':
size = atoi(optarg) * MB;
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-19 3:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-19 3:19 [patch 10/26] mm/gup_benchmark: add a missing "w" to getopt string akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox