From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB2FCA9EA9 for ; Fri, 18 Oct 2019 15:57:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C2B372082C for ; Fri, 18 Oct 2019 15:57:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hOVWoIm1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2B372082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4A4098E0005; Fri, 18 Oct 2019 11:57:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 454098E0003; Fri, 18 Oct 2019 11:57:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36A7A8E0005; Fri, 18 Oct 2019 11:57:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 17DA48E0003 for ; Fri, 18 Oct 2019 11:57:50 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id A440E611E for ; Fri, 18 Oct 2019 15:57:49 +0000 (UTC) X-FDA: 76057361058.22.can59_272aa9ca38a12 X-HE-Tag: can59_272aa9ca38a12 X-Filterd-Recvd-Size: 3088 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Oct 2019 15:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yYmrwGKEGtVRfsP/gPNywSLmmglMNKPJ/qLufe/HUsE=; b=hOVWoIm1RKwBJaTEP6/T2XsPV tw2x3CgSD9FqbMlobDs1zAlbvyrPiwICtqKXNcmcqb/fgxWd0P2HOg62zbx/Gty8fLoqSkcx8FC8l zjLbwT+w+gyn19WaE/nafQ83wIL70oiN2zRatzyZkU5FwSsxJ6ib0krzi/ycltJbcsbyUG28D/jhD vMy+6dPYmDJVp26leBsj6DfSNx2k9pOf06sVu4YCReNBKPE0KdD8tGne8MWflSusVtTxwgb7ImHRJ wjiu8si97RqyAVaot+giqDbmXCeWDQ/rq33Giju7Dx3UuiP3wCGur1pEPzfqTTr8r7cKWmAHSWrzF IU91TgbNQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLUdL-00086G-K0; Fri, 18 Oct 2019 15:57:43 +0000 Date: Fri, 18 Oct 2019 08:57:43 -0700 From: Christoph Hellwig To: Steven Price Cc: linux-mm@kvack.org, Mark Rutland , Peter Zijlstra , Catalin Marinas , Dave Hansen , "H. Peter Anvin" , linux-riscv@lists.infradead.org, Will Deacon , "Liang, Kan" , Alexandre Ghiti , x86@kernel.org, Ingo Molnar , Palmer Dabbelt , Albert Ou , Arnd Bergmann , =?iso-8859-1?B?Suly9G1l?= Glisse , Borislav Petkov , Andy Lutomirski , Paul Walmsley , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , linux-kernel@vger.kernel.org, James Morse , Andrew Morton Subject: Re: [PATCH v12 07/22] riscv: mm: Add p?d_leaf() definitions Message-ID: <20191018155743.GG25386@infradead.org> References: <20191018101248.33727-1-steven.price@arm.com> <20191018101248.33727-8-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018101248.33727-8-steven.price@arm.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + return pud_present(pud) > + && (pud_val(pud) & (_PAGE_READ | _PAGE_WRITE | _PAGE_EXEC)); > +} The operators always need to go before the line break, not after it per linux coding style. There are a few more spots like this, so please audit the whole series for it.