From: Matthew Wilcox <willy@infradead.org>
To: Song Liu <songliubraving@fb.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, matthew.wilcox@oracle.com,
kernel-team@fb.com, william.kucharski@oracle.com,
kirill.shutemov@linux.intel.com,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] mm,thp: recheck each page before collapsing file THP
Date: Fri, 18 Oct 2019 07:25:23 -0700 [thread overview]
Message-ID: <20191018142523.GL32665@bombadil.infradead.org> (raw)
In-Reply-To: <20191018050832.1251306-1-songliubraving@fb.com>
On Thu, Oct 17, 2019 at 10:08:32PM -0700, Song Liu wrote:
> + /* double check the page is correct and clean */
> + if (unlikely(!PageUptodate(page)) ||
> + unlikely(PageDirty(page)) ||
> + unlikely(page->mapping != mapping)) {
That's kind of an ugly way of writing it. Why not more simply:
if (unlikely(!PageUptodate(page) || PageDirty(page) ||
page->mapping != mapping)) {
prev parent reply other threads:[~2019-10-18 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 5:08 Song Liu
2019-10-18 13:06 ` Rik van Riel
2019-10-18 13:34 ` Kirill A. Shutemov
2019-10-18 15:41 ` Rik van Riel
2019-10-18 16:23 ` Song Liu
2019-10-18 14:25 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018142523.GL32665@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kernel-team@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=songliubraving@fb.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox