From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B888CA9EA1 for ; Fri, 18 Oct 2019 11:58:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1DE6121852 for ; Fri, 18 Oct 2019 11:58:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=codeblueprint-co-uk.20150623.gappssmtp.com header.i=@codeblueprint-co-uk.20150623.gappssmtp.com header.b="HFD3g+Y6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DE6121852 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeblueprint.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C82D68E000A; Fri, 18 Oct 2019 07:58:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C337C8E0003; Fri, 18 Oct 2019 07:58:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B48DA8E000A; Fri, 18 Oct 2019 07:58:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 8D3338E0003 for ; Fri, 18 Oct 2019 07:58:53 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 21AA882D35F6 for ; Fri, 18 Oct 2019 11:58:53 +0000 (UTC) X-FDA: 76056758946.09.top00_87b6144f7c23b X-HE-Tag: top00_87b6144f7c23b X-Filterd-Recvd-Size: 4217 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Oct 2019 11:58:52 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id z9so5941405wrl.11 for ; Fri, 18 Oct 2019 04:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeblueprint-co-uk.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3DByddWkc5cdTXqfZ8p4x/nfiNubhnhdBlB/o+i+ezM=; b=HFD3g+Y6OPB8fRJSvhg77Uh3VrsobKCLs+qlqxAsDrwyyaIR1S28n2tEgpMGmME3N1 eSC8Y5L4spPuKlYR8IDXqVqPNkE3wCI57nEpQix5fZ1YSbdbMHfNnJ2PpqBII60CfCEy Ok14KMQdXroVK9EVkaLhU/WnvCdAn0n9Yah3KkgBKAeK6jWnnL950i+rFk0vvprF+Kgl VqJvd/gOuFEwIWQMsWaydU/DXQuhWBkZ7YMJEinq57kTrYMMSQMVXzK9KiODoYDMp4BE FlsEC7VTKImLcUvhnKjXjyBaTk5xpaLL5zLi8eShGH+77khULSLWGpfm6eAmW0CvOW3c TUUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3DByddWkc5cdTXqfZ8p4x/nfiNubhnhdBlB/o+i+ezM=; b=oZYxZAmrmK/4Io3/VOYpAjYosMTvGYzVL33AhSc6qr0rnesUp23wLXzirzvgG1/vX4 EburTl/zYVWSWPjGSFY6vYf9XvaNSYOTZBZTu+TYJ9ioLsj8G1PEnVlSILNK0Qb6wSCH Q1wDpo9iYa89vFyoalQgSOcOU5rOBigLWCZgW5Y0JzDt8OMlcuiTmnWtQ9psbEl2bf0b 3o+sT3jHs8UxZm/4kwHgmhTbW/MvwEqEkRUqDGGlpT4kfnr7V1kPGe7cgj2Avv2NPEYD vceaAIsg+jTbqnmGMocSh5ZdicUbigFHfLfTnQhznAb04mZfoHTyYyrJGbtVCQkm5otQ ixsA== X-Gm-Message-State: APjAAAUgnXgGhgXOKRtj6v94V33nzA8MZzuV+2+HFKAo2aq8Ox3a7saS an0tpMAheBB/Az0Sd/+9Mhwd0g== X-Google-Smtp-Source: APXvYqzdh7H6730oJvDIxHy9u1G9t2x+96YrbWxez+zHkilicBfh+IJpTmhTpIA8Xbhv6dcEfu+6hg== X-Received: by 2002:a5d:638b:: with SMTP id p11mr7031669wru.372.1571399931236; Fri, 18 Oct 2019 04:58:51 -0700 (PDT) Received: from localhost (97e34ace.skybroadband.com. [151.227.74.206]) by smtp.gmail.com with ESMTPSA id a204sm6947970wmh.21.2019.10.18.04.58.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Oct 2019 04:58:50 -0700 (PDT) Date: Fri, 18 Oct 2019 12:58:49 +0100 From: Matt Fleming To: Mel Gorman Cc: Andrew Morton , Michal Hocko , Vlastimil Babka , Thomas Gleixner , Borislav Petkov , Linux-MM , Linux Kernel Mailing List Subject: Re: [PATCH 0/3] Recalculate per-cpu page allocator batch and high limits after deferred meminit Message-ID: <20191018115849.GH4065@codeblueprint.co.uk> References: <20191018105606.3249-1-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018105606.3249-1-mgorman@techsingularity.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 18 Oct, at 11:56:03AM, Mel Gorman wrote: > A private report stated that system CPU usage was excessive on an AMD > EPYC 2 machine while building kernels with much longer build times than > expected. The issue is partially explained by high zone lock contention > due to the per-cpu page allocator batch and high limits being calculated > incorrectly. This series addresses a large chunk of the problem. Patch 1 > is mostly cosmetic but prepares for patch 2 which is the real fix. Patch > 3 is definiely cosmetic but was noticed while implementing the fix. Proper > details are in the changelog for patch 2. > > include/linux/mm.h | 3 --- > mm/internal.h | 3 +++ > mm/page_alloc.c | 33 ++++++++++++++++++++------------- > 3 files changed, 23 insertions(+), 16 deletions(-) Just to confirm, these patches don't fix the issue we're seeing on the EPYC 2 machines, but they do return the batch sizes to sensible values.